Skip to content

Fix scripts with empty text not getting recompiled #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
korri123 merged 1 commit into from
Jun 11, 2026
Merged

Fix scripts with empty text not getting recompiled #267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion nvse/nvse/Hooks_Script.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1120,10 +1120,15 @@ void __fastcall PostScriptCompileSuccess(Script* script, ScriptBuffer* scriptBuf
// - If Script->Compile is called in the GECK outside of the vanilla code this will NOT be hit
// - Not sure if this is a problem, maybe all plugins should be compiling scripts via NVSE and we can clean up the runtime hooks as well?
static char __fastcall CompileScriptHook(void* context, void* edx, Script* script, ScriptBuffer *buf) {
if (buf == nullptr || buf->scriptText == nullptr) {
if (buf == nullptr) {
return 1;
}

if (buf->scriptText == nullptr) {
// Let original compiler take over for empty script text (i.e. cleanup after removing a partial script)
return ThisStdCall<char>(0x5C96E0, context, script, buf);
}

auto precompileResult = HandleBeginCompile(buf, script);
char result = 0;

Expand Down
Loading