docs(cliffs): correct the notes that #83 falsified - #85
Merged
Conversation
An audit after the multisample grid fix. Several documents still asserted the opposite of what is now measured, and three of them were TITLES - the lines a reader trusts fastest. - `cliffs-NOTES.md` gains a STATUS banner at the top. The root cause sat at line 636 under 635 lines of superseded investigation, so a cold reader met the wrong conclusions first. The banner carries the current recall and orientation numbers, points at the ROOT CAUSE section, and names the specific stale figures below it (the ~90%, the 12.5%/29.8%/8.1%/11.7% tables, the 0.806/0.938/0.853 recalls) as pre-fix. - Two headings there were plainly wrong: "validated ~90% tile-for-tile", and "Validation result: EXACT since 2026-07-30 (the residual is resolved)" - which was only ever true of Nauvis. - `vulcanus-cliffs-NOTES.md` gains the same banner, and its "## The residual is in the RULE, not the fields" section is marked FALSIFIED. Its experiment and numbers are sound; the verdict is not. The fixture it substitutes came through calculate_tile_properties (1-tile grid) while the cliff generator reads a 4-tile grid, so the fixture and the port shared the mistake and could never disagree. - `client-preview-ROADMAP.md` said the residual "is now believed to be a RULE error rather than a field error (PR #57)". It was a field error. Corrected with why PR #57's substitution missed it. - `vulcanusCliffCornerFields.spec.ts`'s doc header and `vulcanusOreCliffSeparation.spec.ts`'s describe name both still claimed the fields are exact and the residual is in the rule. Both now say the fields are exact IN THE TILE CHANNEL, which is the accurate and more useful statement. - CLAUDE.md's spec-file count was 143; it is 152. No behaviour change. `pnpm run verify`: 310 files clean, 1306 passed / 3 skipped, preview 12 passed - the suite is green on an unloaded machine, which also confirms the earlier local timeouts were load and not a regression. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GRx1CU29RKLsRuUAErEDRB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A documentation audit after the multisample grid fix (#83). Several documents still asserted the opposite of what is now measured - and three of them were titles, the lines a reader trusts fastest.
Fixed
cliffs-NOTES.mdgains a STATUS banner at the top. The root cause sat at line 636, under 635 lines of superseded investigation, so a cold reader met the wrong conclusions first. The banner carries current recall/orientation numbers, points at the ROOT CAUSE section, and names the specific stale figures below it (the~90%, the 12.5% / 29.8% / 8.1% / 11.7% tables, the 0.806 / 0.938 / 0.853 recalls) as pre-fix.vulcanus-cliffs-NOTES.mdgains the same banner, and its## The residual is in the RULE, not the fieldssection is marked FALSIFIED. Its experiment and numbers are sound; the verdict is not. The fixture it substitutes came throughcalculate_tile_properties(1-tile grid) while the cliff generator reads a 4-tile grid - so the fixture and the port shared the mistake and could never disagree.client-preview-ROADMAP.mdsaid the residual "is now believed to be a rule error rather than a field error (PR measure(#24): no ore/cliff exclusion exists; #18's residual is the RULE, not the fields #57)". It was a field error. Corrected, with why measure(#24): no ore/cliff exclusion exists; #18's residual is the RULE, not the fields #57's substitution missed it.vulcanusCliffCornerFields.spec.ts's doc header andvulcanusOreCliffSeparation.spec.ts'sdescribename both still claimed the fields are exact and the residual is in the rule. Both now say the fields are exact in the tile channel - accurate, and the more useful statement.Note
No behaviour change.
pnpm run verify: 310 files clean, 1306 passed / 3 skipped, preview 12 passed. The suite is green on an unloaded machine, which also confirms the local timeouts seen while landing #83 were machine load and not a regression - cleanmainshowed the identical 8 at the time.🤖 Generated with Claude Code
https://claude.ai/code/session_01GRx1CU29RKLsRuUAErEDRB