fix: Prevent crashes when canceling download tasks#870
Open
wise-danya wants to merge 2 commits intowonday:masterfrom
Open
fix: Prevent crashes when canceling download tasks#870wise-danya wants to merge 2 commits intowonday:masterfrom
wise-danya wants to merge 2 commits intowonday:masterfrom
Conversation
This commit addresses an issue where calling `this.lastRNBFTask.cancel` could result in a "is not a function" error. The fix adds a type check to ensure that cancel is a function before attempting to call it.
We are experiencing same issue |
|
when is it possible to merge this, facing the same issue |
|
@wonday You could check this out |
|
@wonday any chance this could get merged? it's a minimal change and fixes a crash that we've been experiencing |
|
@wonday can you please check? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a critical issue where the app crashes when attempting to cancel certain tasks within the PDF component. The crash occurs because the cancel method is called on
lastRNBFTaskwithout first checking if it is a function.Problem
When the component updates, unmounts, or when a new download is initiated, the app attempts to cancel any ongoing task represented by
lastRNBFTask. However, iflastRNBFTask.cancelis not a function, this leads to an uncaught exception, causing the app to crash.Solution
Safety checks have been implemented to ensure that
lastRNBFTask.cancelis a function before any attempt is made to call it. The existing checks for the presence oflastRNBFTaskhave been retained, and the cleanup behavior (settinglastRNBFTaskto null) has been preserved.Screenshots