Skip to content

fix: remove underline for mentions of own messages in chat bubbles - WPB-20367#4149

Closed
SyamalaHari wants to merge 5 commits intodevelopfrom
fix/WPB-20367_Mentions-in-chat-bubbles-should-not-be-underlined
Closed

fix: remove underline for mentions of own messages in chat bubbles - WPB-20367#4149
SyamalaHari wants to merge 5 commits intodevelopfrom
fix/WPB-20367_Mentions-in-chat-bubbles-should-not-be-underlined

Conversation

@SyamalaHari
Copy link
Copy Markdown
Contributor

@SyamalaHari SyamalaHari commented Jan 19, 2026

BugWPB-20367 [iOS] Mentions in chat bubbles should not be underlined

…and add underline for links of other messages in chat bubbles

Issue

Fixing two issues:

  1. Fix: Mentions in chat bubbles should not be underlined
  2. Improvement: Links in chat bubbles of others messages should be underlined

Solution: Removed globally applying link attributes and applying individually to links and mentions

Testing

  1. Others messages links must have underline
  2. Own messages mentions must not have underline

Optional: attachments like images, videos, etc.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

…and add underline for links of other messages in chat bubbles
@SyamalaHari SyamalaHari changed the title fix: remove underline for mentions of own messages in chat bubbles-WPB-20367 fix: remove underline for mentions of own messages in chat bubbles - WPB-20367 Jan 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 19, 2026

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 75cc4da.

♻️ This comment has been updated with latest results.

Summary: workflow run #21832510256

Copy link
Copy Markdown
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good left a todo

Copy link
Copy Markdown
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Apologies for the late review.

@netbe
Copy link
Copy Markdown
Collaborator

netbe commented Jan 28, 2026

@SyamalaHari I think you can target 4.15 too here release/cycle-4.15

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 9, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants