Skip to content

#2011 build pipeline for litepicker#2012

Open
hansmorb wants to merge 5 commits into
masterfrom
enhancement/issue-2011
Open

#2011 build pipeline for litepicker#2012
hansmorb wants to merge 5 commits into
masterfrom
enhancement/issue-2011

Conversation

@hansmorb

@hansmorb hansmorb commented Feb 2, 2026

Copy link
Copy Markdown
Contributor

closes #2011
Done:

  • Tested if Litepicker looks different in Playground on this branch and on master. Look the same.
    TODO:
  • Evaluate, if if its bad that build-plugin now takes a long time. I am presuming this is the case, because it runs the build of Litepicker on each version.

@codecov

codecov Bot commented Feb 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.12%. Comparing base (f84d8c1) to head (6047429).
⚠️ Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
src/Plugin.php 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2012      +/-   ##
============================================
- Coverage     54.14%   54.12%   -0.02%     
  Complexity     2667     2667              
============================================
  Files            98       98              
  Lines         11667    11674       +7     
============================================
+ Hits           6317     6319       +2     
- Misses         5350     5355       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Feb 2, 2026

Copy link
Copy Markdown

@hansmorb hansmorb requested a review from datengraben February 2, 2026 15:09
@hansmorb hansmorb force-pushed the enhancement/issue-2011 branch from 3a9a623 to 1f96389 Compare February 4, 2026 13:24
@hansmorb hansmorb force-pushed the enhancement/issue-2011 branch from 1f96389 to 318e495 Compare February 5, 2026 11:28
@datengraben

Copy link
Copy Markdown
Contributor

@hansmorb I merged #1687 and #1828 ...

So you are able to continue this 👍?

You want to remove pre-build litepicker.js from this repo correct?

@datengraben

datengraben commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

Why not put Litepicker into its own submodule inside the repo?

I checked the PR sources. This looks fine!

If I understand correctly:

(1) we remove litepicker pre-build assets files
(2) we add dependency to litepicker repo #master
(3) we add litepicker vendored files (in node_modules) to the build-step in Gruntfile

maybe we can pin (2) to a specific version instead of master.

@datengraben datengraben left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added comments in the pr thread.

@hansmorb

Copy link
Copy Markdown
Contributor Author

@hansmorb I merged #1687 and #1828 ...

So you are able to continue this 👍?

You want to remove pre-build litepicker.js from this repo correct?

Yes, I am busy with GBFS right now but I will pick this up afterwards. Not too much work left I think but I still need to evaluate if it's worth it having to build Litepicker every time we build the plugin. Also bc building Litepicker takes a long time (2 minutes or so)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proper build pipeline for Litepicker

2 participants