Skip to content

Fix bug when selecting indented proof blocks - #433

Merged
whonore merged 4 commits into
whonore:mainfrom
mateoxh:textobj
Aug 2, 2026
Merged

Fix bug when selecting indented proof blocks#433
whonore merged 4 commits into
whonore:mainfrom
mateoxh:textobj

Conversation

@mateoxh

@mateoxh mateoxh commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

The old code didn't handle the case where the proof block is indented. Maybe we should add tests for this?

@whonore

whonore commented Aug 1, 2026

Copy link
Copy Markdown
Owner

Yes, some tests in tests/vim/ would be great. Something along the lines of:

# tests/vim/proof-block.vader
Given coq (simple-proof-i):
  Goal True.
  Proof.
    auto.
  Qed.

Do (simple-proof-i):
  diP

Expect coq (simple-proof-i):
  Goal True.
  Proof.
  Qed.

@mateoxh

mateoxh commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Writing the tests helped find a couple of bugs but also want to change the behavior in some edge cases, for now I think they're enough.

@whonore
whonore merged commit c5ab7d8 into whonore:main Aug 2, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants