Set 'path' and add fallback for 'includeexpr' - #431
Merged
Conversation
whonore
reviewed
Jul 26, 2026
This reverts commit cb42559.
Contributor
Author
|
Is that the correct |
Owner
|
Thanks, I think this looks good. I'll double check that everything works ok tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until the server is started the command
gfand insert-mode completion forincluded files don't work, so I changed
&pathto point to Rocq's librariesdirectories and added a fallback to
&includeexprwhen the query to Rocqfails.
One small caveat is that for
gfthe filename is first searched in&pathandif it can't be found it is modified with
&includeexprand another search isdone, so (in theory) it may be possible that the file opened by
gfis not thesame one found by Rocq (
&includeexpris always used on the files found with&include).I don't think it's a big issue but remapping
gfis a simple solution.