Skip to content

Conversation

@josepharhar
Copy link
Contributor

@josepharhar josepharhar commented Oct 7, 2025

This PR defines base appearance for select elements which are being rendered as a list box, as opposed to the prior customizable select PR which defined base appearance for drop down select elements.

Fixes #11477

(See WHATWG Working Mode: Changes for more details.)


/form-elements.html ( diff )
/rendering.html ( diff )

@zcorpan
Copy link
Member

zcorpan commented Oct 17, 2025

I filed #11804 , I can review this again when that is fixed.

I would suggest adding tests in this area that check which UA styles are applied, see e.g. https://github.com/web-platform-tests/wpt/blob/master/html/rendering/widgets/the-select-element/select-as-listbox-default-styles.tentative.html

@josepharhar
Copy link
Contributor Author

I filed #11804 , I can review this again when that is fixed.

Thanks, I started a fix: #11805

I would suggest adding tests in this area that check which UA styles are applied, see e.g. https://github.com/web-platform-tests/wpt/blob/master/html/rendering/widgets/the-select-element/select-as-listbox-default-styles.tentative.html

Here is a test I'm working on: https://chromium-review.googlesource.com/c/chromium/src/+/6276680

@josepharhar
Copy link
Contributor Author

Now that #11804 has been fixed and I have rebased this PR, and we got a resolution in the sizing issue, and we have a positive standards position from mozilla, this PR is ready for review.

@zcorpan
Copy link
Member

zcorpan commented Dec 15, 2025

Some of the linked tests are tentative, is there a PR to make them not tentative?

@josepharhar
Copy link
Contributor Author

Some of the linked tests are tentative, is there a PR to make them not tentative?

I added a chromium patch to make them non-tentative, which will generate a WPT PR later

@zcorpan zcorpan merged commit 84bf1e8 into whatwg:main Dec 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Base appearance for list box select elements

3 participants