-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Define base appearance for list box select elements #11758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I filed #11804 , I can review this again when that is fixed. I would suggest adding tests in this area that check which UA styles are applied, see e.g. https://github.com/web-platform-tests/wpt/blob/master/html/rendering/widgets/the-select-element/select-as-listbox-default-styles.tentative.html |
Thanks, I started a fix: #11805
Here is a test I'm working on: https://chromium-review.googlesource.com/c/chromium/src/+/6276680 |
|
Now that #11804 has been fixed and I have rebased this PR, and we got a resolution in the sizing issue, and we have a positive standards position from mozilla, this PR is ready for review. |
|
Some of the linked tests are tentative, is there a PR to make them not tentative? |
I added a chromium patch to make them non-tentative, which will generate a WPT PR later |
This PR defines base appearance for select elements which are being rendered as a list box, as opposed to the prior customizable select PR which defined base appearance for drop down select elements.
Fixes #11477
(See WHATWG Working Mode: Changes for more details.)
/form-elements.html ( diff )
/rendering.html ( diff )