perf: use selector subscriptions in diagram picker#38
Merged
charlesrhoward merged 1 commit intomainfrom Feb 21, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
charlesrhoward
force-pushed
the
codex/feat-26-diagram-picker-selectors
branch
from
db80e51 to
18831a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useCanvasStore()full-store subscription inDiagramPickerValidation
pnpm buildCloses #26
Note
Low Risk
Pure refactor of how state is selected in a UI component; minimal behavioral risk aside from potential missed selector wiring causing stale UI updates.
Overview
Refactors
DiagramPickerto replace the fulluseCanvasStore()subscription with per-field selector subscriptions for only the state slices and actions it uses, reducing unnecessary re-renders.No behavior changes to diagram loading/saving/renaming/deleting; this is a component-level performance optimization.
Written by Cursor Bugbot for commit 18831a9. This will update automatically on new commits. Configure here.