Skip to content

fix metadata logic - #454

Merged
n0vad3v merged 1 commit into
masterfrom
fix-metadata-recursive
Jun 9, 2026
Merged

fix metadata logic#454
n0vad3v merged 1 commit into
masterfrom
fix-metadata-recursive

Conversation

@n0vad3v

@n0vad3v n0vad3v commented Jun 6, 2026

Copy link
Copy Markdown
Member

This PR fixes a recursion issue in metadata handling that could cause requests to hang when the metadata directory is not writable (for example, due to disk full or permission errors). ReadMetadata and WriteMetadata now return explicit errors, recursive self-calls were removed, and call sites were updated to handle failures gracefully. Tests were added to cover both normal metadata flow and failure cases for unavailable metadata paths.

Aims to solve: #453

@github-actions

github-actions Bot commented Jun 6, 2026

Copy link
Copy Markdown

Report Summary

┌──────────────────────────────────────────────┬──────────┬─────────────────┬─────────┐
│                    Target                    │   Type   │ Vulnerabilities │ Secrets │
├──────────────────────────────────────────────┼──────────┼─────────────────┼─────────┤
│ ghcr.io/webp-sh/webp_server_go (debian 13.5) │  debian  │        0        │    -    │
├──────────────────────────────────────────────┼──────────┼─────────────────┼─────────┤
│ usr/bin/webp-server                          │ gobinary │        0        │    -    │
└──────────────────────────────────────────────┴──────────┴─────────────────┴─────────┘
Legend:
- '-': Not scanned
- '0': Clean (no security findings detected)


@n0vad3v
n0vad3v merged commit 45bd516 into master Jun 9, 2026
5 checks passed
@n0vad3v
n0vad3v deleted the fix-metadata-recursive branch June 9, 2026 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant