Skip to content

fix: host-based mapping with local backend#408

Draft
HolgerHuo wants to merge 1 commit into
webp-sh:masterfrom
HolgerHuo:fix/host-map-local-backend
Draft

fix: host-based mapping with local backend#408
HolgerHuo wants to merge 1 commit into
webp-sh:masterfrom
HolgerHuo:fix/host-map-local-backend

Conversation

@HolgerHuo

Copy link
Copy Markdown
Contributor

fix host-based mapping to local backend not working

@HolgerHuo
HolgerHuo marked this pull request as draft June 26, 2025 08:05
@HolgerHuo
HolgerHuo marked this pull request as draft June 26, 2025 08:05
@HolgerHuo
HolgerHuo force-pushed the fix/host-map-local-backend branch from e1927c4 to 9dfe8b6 Compare June 26, 2025 09:21
@HolgerHuo

Copy link
Copy Markdown
Contributor Author

This pr fixes local backend cannot be used in img_map. However, there's still room for further improvements:

  1. Maybe we should handle url parsing of remote backends in config.go so that they don't have to be parsed on every request
  2. The ProxyMode switch should be fully deprecated, and this may require some in-depth updates to the codebase.

This PR should be ready for merge for now. Should I have time to implement the above mentioned improvements, I'll put them in another PR.

P.S.: The failed workflow should be an apt issue. A restart of the workflow run should fix it.

@HolgerHuo
HolgerHuo marked this pull request as ready for review June 26, 2025 09:26
@HolgerHuo
HolgerHuo marked this pull request as draft June 26, 2025 09:47
@HolgerHuo

Copy link
Copy Markdown
Contributor Author

Seems still buggy in getId() 😂 I'll try fix it later

@n0vad3v

n0vad3v commented Jan 4, 2026

Copy link
Copy Markdown
Member

Hello @HolgerHuo , will there be more updates on this PR? 👀

@HolgerHuo

HolgerHuo commented Jan 4, 2026

Copy link
Copy Markdown
Contributor Author

Sorry for the delay. I was a little busy last year and I almost forgot about this PR. Maybe I will find some time to fix this bug.

The ProxyMode switch should be fully deprecated, and this may require some in-depth updates to the codebase.

This should also be implemented so that we can fix this bug more gracefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants