Skip to content

feat(finance): add balance and valuation commands#8

Open
JSONbored wants to merge 1 commit into
we-promise:mainfrom
JSONbored:codex/feat-cli-financial-history
Open

feat(finance): add balance and valuation commands#8
JSONbored wants to merge 1 commit into
we-promise:mainfrom
JSONbored:codex/feat-cli-financial-history

Conversation

@JSONbored
Copy link
Copy Markdown

Summary

  • Add financial history and account-state commands.

What changed

  • Adds balance-sheet show.
  • Adds balances list/show.
  • Adds family-settings show.
  • Adds valuations list/show/create/update with dry-run-first writes and --upsert on create.
  • Reworks status money parsing to prefer API money/currency fields instead of assuming EUR-only formatting.
  • Escapes path parameters for the new financial show/update routes.

Why

  • These endpoints are part of the merged Sure API and are needed for CLI parity around balance history, family state, and manual valuations.

Validation

  • go test -count=1 ./...
  • go test -race ./...
  • go vet ./...
  • tools/validate-samples.sh
  • git diff --check
  • gitleaks detect --no-git --redact --source . --verbose

Notes

  • Draft for review. This branch includes local helper/client support so it can validate independently; it may need a small rebase after earlier CLI helper/API-client PRs merge.

Add balance sheet, balance history, family settings, and valuation commands with dry-run-first valuation writes. Update status to prefer API money/currency fields and add focused tests for valuation payloads and command registration.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 6, 2026

Warning

Rate limit exceeded

@JSONbored has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 59 minutes and 50 seconds before requesting another review.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 77fdae2e-49cb-426f-b7e0-dd7264f2f1d9

📥 Commits

Reviewing files that changed from the base of the PR and between 48830d1 and f7c35c3.

📒 Files selected for processing (8)
  • .gitignore
  • README.md
  • cmd/sure-cli/root/financial_cmds.go
  • cmd/sure-cli/root/financial_cmds_test.go
  • cmd/sure-cli/root/root.go
  • cmd/sure-cli/root/status_cmd.go
  • internal/api/client.go
  • internal/insights/amount.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@JSONbored JSONbored marked this pull request as ready for review May 7, 2026 06:29
@superagent-security superagent-security Bot added contributor:verified Contributor passed trust analysis. pr:verified PR passed security analysis. labels May 7, 2026
@jjmata jjmata requested a review from dgilperez May 13, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor:verified Contributor passed trust analysis. pr:verified PR passed security analysis.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant