Fix atomic ops for Apple clang/libc++ compatibility - #5
Open
alisterburt wants to merge 1 commit into
Open
Conversation
Apple's libc++ doesn't support std::atomic<float/double>::fetch_add (C++20 floating-point atomics are incomplete). Replace std::atomic-based implementation with OpenMP atomic pragmas, which compile to equivalent hardware instructions. Add type trait to deduce real type from complex types, eliminating need for explicit template arguments at call sites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM spiel:
@dtegunov I ran into issues building this on my work laptop - claude doesn't think there are perf implications to this but a review before merge would be good