-
Notifications
You must be signed in to change notification settings - Fork 140
updating aria-live=off to match the aligned implementations. #2677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cookiecrook
wants to merge
3
commits into
main
Choose a base branch
from
update-aria-live-off
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
scottaohara
approved these changes
Nov 20, 2025
Contributor
Author
|
Added Agenda+ to the related issue, just to make sure this doesn't slip by any WG members accidentally. Removing the duplicate keyword here. |
Contributor
|
Assigning myself to test orca. |
smhigley
approved these changes
Dec 4, 2025
Contributor
Author
|
Braille tests revealed no unexpected results. @spectranaut Assuming Orca aligns with the others, you can merge since this has two other approvals. |
cookiecrook
commented
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2144
Closes #2653
Closes #2664
Closes #2674
Updating
aria-live="off"to match the aligned implementations:… Effectively that the following are not live regions, becausearia-live="off"negates all live region functionality.role="marquee"role="timer"<div aria-live="off">(aria-liveis global, and the default isoffon everything, so this is identical to<div>)See the issues for more detail.
marqueeandtimerlisted as live region roles but have intrinsicaria-live="off"#2144aria-live="off"that is less confusing to authors #2664Preview | Diff