fix: return 504 instead of RepoNotFound 401 when upstream is unreachable - #62
Open
bo0tzz wants to merge 1 commit into
Open
fix: return 504 instead of RepoNotFound 401 when upstream is unreachable#62bo0tzz wants to merge 1 commit into
bo0tzz wants to merge 1 commit into
Conversation
check_commit_hf treated any transport failure (connect error, timeout, DNS hiccup) as "repo does not exist", which the routes turned into error_repo_not_found() — an HTTP 401 that huggingface_hub maps to the non-retryable RepositoryNotFoundError. Under parallel CI load a single failed upstream HEAD therefore hard-failed a whole download, while the repo was perfectly fine. check_commit_hf now returns a tri-state: True (exists), False (upstream rejected with a non-5xx status), None (unreachable or 5xx). The tenacity retry, previously dead code because the exception was swallowed before it could fire, now retries the None case. Callers map None to error_proxy_timeout() (504) so clients retry, and a failed commit-sha lookup after successful existence checks is likewise a 504 rather than a phantom "repo not found".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_commit_hf treated any transport failure (connect error, timeout, DNS hiccup) as "repo does not exist", which the routes turned into error_repo_not_found() — an HTTP 401 that huggingface_hub maps to the non-retryable RepositoryNotFoundError. Under parallel CI load a single failed upstream HEAD therefore hard-failed a whole download, while the repo was perfectly fine.
check_commit_hf now returns a tri-state: True (exists), False (upstream rejected with a non-5xx status), None (unreachable or 5xx). The tenacity retry, previously dead code because the exception was swallowed before it could fire, now retries the None case. Callers map None to error_proxy_timeout() (504) so clients retry, and a failed commit-sha lookup after successful existence checks is likewise a 504 rather than a phantom "repo not found".