fix: return upstream 4xx instead of 504 for canonical repo files - #61
Open
bo0tzz wants to merge 1 commit into
Open
fix: return upstream 4xx instead of 504 for canonical repo files#61bo0tzz wants to merge 1 commit into
bo0tzz wants to merge 1 commit into
Conversation
Canonical (no-org) repos like xlm-roberta-base were excluded from the paths-info metadata branch in _file_realtime_stream because of the "org is not None" guard, falling back to _remote_file_metadata which collapsed any upstream error into a ProxyTimeout 504. The HF paths-info API handles canonical names via a 307 redirect that the proxy already follows, so the guard can simply allow org=None. Additionally, _remote_file_metadata now reports the upstream status code so genuine 404/401/403 responses pass through instead of being relabeled as 504; network failures still map to ProxyTimeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canonical (no-org) repos like xlm-roberta-base were excluded from the paths-info metadata branch in _file_realtime_stream because of the "org is not None" guard, falling back to _remote_file_metadata which collapsed any upstream error into a ProxyTimeout 504. The HF paths-info API handles canonical names via a 307 redirect that the proxy already follows, so the guard can simply allow org=None.
Additionally, _remote_file_metadata now reports the upstream status code so genuine 404/401/403 responses pass through instead of being relabeled as 504; network failures still map to ProxyTimeout.