Skip to content

Implement vhost_traffic_status_upstream_no_cache filter#194

Open
heikkiorsila wants to merge 3 commits into
vozlt:masterfrom
Seravo:master
Open

Implement vhost_traffic_status_upstream_no_cache filter#194
heikkiorsila wants to merge 3 commits into
vozlt:masterfrom
Seravo:master

Conversation

@heikkiorsila

Copy link
Copy Markdown

This enables monitoring upstream backend events that are configured not to
use cache.

Add the following line to nginx config to create a group:

    vhost_traffic_status_filter_upstream_no_cache "NO_CACHE";

@vozlt

vozlt commented Sep 4, 2022

Copy link
Copy Markdown
Owner

Thanks for the pull request for improvement. But do you need to put non-cached statistics inside serverZones? As far as I know you can already use the information(miss, bypass, expired, stale, updating, revalidated, hit, scarce) in serverZones to calculate statistics for non-cached items. I think it is correct to calculate it through a 3rd party program.

@vozlt vozlt requested review from SuperQ and u5surf September 4, 2022 16:04

@u5surf u5surf left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @heikkiorsila
Thanks feature PR. We didn’t find obviously what to expect on this feature. Because I also couldn’t find any differences between vhost_traffic_status_zone and this feature.

Can you add some tests or share your scenarios to explain your expectation on this feature? It is necessary for us and our users to make sense this feature properly.

vozlt and others added 3 commits October 3, 2022 09:40
…g the ngx_http_vhost_traffic_status_display_get_size() function
* To reduce the ci build time
This enables monitoring upstream backend events that are configured not to
use cache.

Add the following line to nginx config to create a group:

        vhost_traffic_status_filter_upstream_no_cache "NO_CACHE";
@u5surf

u5surf commented Oct 18, 2022

Copy link
Copy Markdown
Collaborator

@ypcs Hi, Thanks following about this PR.

We almost agree with what @vozlt said the below

But do you need to put non-cached statistics inside serverZones? As far as I know you can already use the information(miss, bypass, expired, stale, updating, revalidated, hit, scarce) in serverZones to calculate statistics for non-cached items. I think it is correct to calculate it through a 3rd party program.

Do you have any another reasons that the feature is necessary for this modules?
And can you add some tests or share your expected scenarios to explain the necessity on this feature?
We'll judge based on it whether this PR should merge or not.

@ypcs

ypcs commented Oct 19, 2022

Copy link
Copy Markdown

Hi. We're currently evaluating if this is necessary, I'll post update later, and we'll provide tests then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants