Implement vhost_traffic_status_upstream_no_cache filter#194
Implement vhost_traffic_status_upstream_no_cache filter#194heikkiorsila wants to merge 3 commits into
Conversation
|
Thanks for the pull request for improvement. But do you need to put non-cached statistics inside serverZones? As far as I know you can already use the information(miss, bypass, expired, stale, updating, revalidated, hit, scarce) in serverZones to calculate statistics for non-cached items. I think it is correct to calculate it through a 3rd party program. |
u5surf
left a comment
There was a problem hiding this comment.
Hi, @heikkiorsila
Thanks feature PR. We didn’t find obviously what to expect on this feature. Because I also couldn’t find any differences between vhost_traffic_status_zone and this feature.
Can you add some tests or share your scenarios to explain your expectation on this feature? It is necessary for us and our users to make sense this feature properly.
…g the ngx_http_vhost_traffic_status_display_get_size() function
* To reduce the ci build time
This enables monitoring upstream backend events that are configured not to
use cache.
Add the following line to nginx config to create a group:
vhost_traffic_status_filter_upstream_no_cache "NO_CACHE";
|
@ypcs Hi, Thanks following about this PR. We almost agree with what @vozlt said the below
Do you have any another reasons that the feature is necessary for this modules? |
|
Hi. We're currently evaluating if this is necessary, I'll post update later, and we'll provide tests then. |
This enables monitoring upstream backend events that are configured not to
use cache.
Add the following line to nginx config to create a group: