Open
Conversation
Andeshog
reviewed
Nov 13, 2025
Andeshog
reviewed
Nov 13, 2025
Andeshog
reviewed
Nov 13, 2025
Q3rkses
requested changes
Mar 8, 2026
Contributor
Q3rkses
left a comment
Q3rkses
left a comment
There was a problem hiding this comment.
delete the log files, otherwise lgtm
anbit-adhi
force-pushed
the
anbit/guidance
branch
2 times, most recently
from
dbec5e2 to
e38d16d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addition:
In this update to the vortex_msgs package, I have added a new service definition that allows switching between different LOS guidance methods at runtime. The new service is called SetLosMode.srv and is used by the los_guidance node to select the active LOS method while the node is running.
This addition makes it possible to dynamically change between multiple LOS systems, without restarting the system or reloading parameters. It is a key step in making the LOS guidance system more flexible and modular.