chore: add assert_nth_scalar! macro and simplify test assertions #5960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseph-isaacs
force-pushed
the
claude/simplify-vortex-tests-T9eT4
branch
from
6d38c82 to
949a98a
Compare
Add a centralized `assert_nth_scalar!` macro in vortex-array for testing scalar values at specific indices. This replaces duplicate local macro definitions in encoding crates and simplifies verbose scalar assertions. Changes: - Add `assert_nth_scalar!` macro to vortex-array/src/arrays/assertions.rs - Remove duplicate macro definitions from zstd, pco, and fsst test files - Update listview.rs builder tests to use the new macro - Update fastlanes bitpacking operations tests - Update vortex-layout struct reader tests - Simplify fuzz/mask tests to use assert_arrays_eq! instead of manual is_valid and scalar_at checks - Remove redundant validity assertions after assert_arrays_eq! - Simplify delta compress roundtrip tests to use assert_arrays_eq! Signed-off-by: Claude <[email protected]>
joseph-isaacs
force-pushed
the
claude/simplify-vortex-tests-T9eT4
branch
from
949a98a to
e5fa6a0
Compare
Signed-off-by: Claude <[email protected]>
Signed-off-by: Claude <[email protected]>
Signed-off-by: Claude <[email protected]>
Signed-off-by: Claude <[email protected]>
Use range iterators to create expected arrays for sequential list data, eliminating boundary-only checks in favor of full array comparisons. Signed-off-by: Claude <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a centralized
assert_nth_scalar!macro in vortex-array for testingscalar values at specific indices. This replaces duplicate local macro
definitions in encoding crates and simplifies verbose scalar assertions.
Changes:
assert_nth_scalar!macro to vortex-array/src/arrays/assertions.rsSigned-off-by: Claude [email protected]