switch Buffer -> BufferHandle in PrimitiveArray #5929
+447
−186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a10y
force-pushed
the
bufferhandles
branch
3 times, most recently
from
67fabe3 to
5d5797b
Compare
Merging this PR will improve performance by ×2.9
Performance Changes
Comparing 
Footnotes
|
Contributor
|
I wonder if we can remove at lot of these buffer calls from tests? |
Contributor
Author
|
I don't think there's another way to get the values out now |
a10y
force-pushed
the
bufferhandles
branch
5 times, most recently
from
9e2ba3b to
ca0b46b
Compare
Contributor
Benchmarks: Random AccessSummary
|
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: CompressionSummary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
joseph-isaacs
approved these changes
Jan 14, 2026
gatesn
previously requested changes
Jan 14, 2026
Contributor
gatesn
left a comment
gatesn
left a comment
There was a problem hiding this comment.
I don't think this is quite right
a10y
force-pushed
the
bufferhandles
branch
4 times, most recently
from
f673643 to
fe957da
Compare
Signed-off-by: Andrew Duffy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fleshes out the BufferHandle type more.
I hid the inner enum and introduced some extra methods to build/unwrap BufferHandles.
This removes the
PrimitiveArray::as_slicemethod, replacing it with aninto_buffer::<T>method which may allocate and copy a new buffer (if the handle points to device memory), or else provides a new Buffer pointing to the existing host memory.This PR is large but a lot of it is just adding
&'s and updating test code to use thebuffer!macro