Skip to content

Revert "feat(retrieve): use tags metadata for cross-subtree retrieval"#1200

Merged
qin-ctx merged 1 commit intomainfrom
revert-1162-codex/issue-1147-tags-retrieval
Apr 3, 2026
Merged

Revert "feat(retrieve): use tags metadata for cross-subtree retrieval"#1200
qin-ctx merged 1 commit intomainfrom
revert-1162-codex/issue-1147-tags-retrieval

Conversation

@zhoujh01
Copy link
Copy Markdown
Collaborator

@zhoujh01 zhoujh01 commented Apr 3, 2026

Reverts #1162

@qin-ctx qin-ctx merged commit fea7c01 into main Apr 3, 2026
5 of 10 checks passed
@qin-ctx qin-ctx deleted the revert-1162-codex/issue-1147-tags-retrieval branch April 3, 2026 06:37
@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenViking project Apr 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅

1162 - PR Code Verified

Compliant requirements:

  • Revert tags-related code from embedding utils
  • Revert tags parameter from client methods
  • Revert test fixtures changes
  • Revert tags handling in services and routers

Requires further human verification:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🏅 Score: 90
🧪 No relevant tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ Recommended focus areas for review

Potential Regression

The zip() call reverted from strict=True to non-strict, which could hide mismatched lengths between resource_uris and temp_uris. Verify this matches the original pre-PR #1162 behavior.

for uri, temp_uri in zip(resource_uris, temp_uris):
API Compatibility

Switched from keyword to positional arguments in _async_client calls. Verify the parameter order matches the _async_client method signatures to avoid argument misalignment.

query, target_uri, session, session_id, limit, score_threshold, filter, telemetry
API Compatibility

Switched from keyword to positional arguments in _async_client calls. Verify the parameter order matches the _async_client method signatures to avoid argument misalignment.

path,
to,
parent,
reason,
instruction,
wait,
timeout,
strict,
ignore_dirs,
include,
exclude,
directly_upload_media,
telemetry=telemetry,

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants