fix: replace hardcoded dashboard table search placeholder#278
Conversation
Signed-off-by: pggdev <princegupta.ns153@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a customizable searchPlaceholder prop to the DataTable component, allowing for more specific filter text across different dashboard views. The Jobs, Pods, and Queues management components were updated to utilize this new prop. Feedback was provided to remove inconsistent spacing before the ellipses in the placeholder strings to ensure UI consistency with the default component styling.
| data={jobs || []} | ||
| onRowClick={handleJobClick} | ||
| disablePagination={true} | ||
| searchPlaceholder="Filter Jobs ..." |
There was a problem hiding this comment.
The placeholder text contains an extra space before the ellipsis. For consistency with the default value defined in the DataTable component (Filter...) and standard UI typography, consider removing the space.
| searchPlaceholder="Filter Jobs ..." | |
| searchPlaceholder="Filter Jobs..." |
| data={pods || []} | ||
| onRowClick={handlePodClick} | ||
| disablePagination={true} | ||
| searchPlaceholder="Filter Pods ..." |
There was a problem hiding this comment.
The placeholder text has an extra space before the ellipsis. Removing this space will ensure the UI remains consistent with the default placeholder style used in the shared DataTable component.
| searchPlaceholder="Filter Pods ..." | |
| searchPlaceholder="Filter Pods..." |
| data={queues || []} | ||
| onRowClick={handleQueueClick} | ||
| disablePagination={true} | ||
| searchPlaceholder="Filter Queues ..." |
There was a problem hiding this comment.
The placeholder text contains an extra space before the ellipsis. It is recommended to remove it to maintain a consistent look and feel across all dashboard tables.
| searchPlaceholder="Filter Queues ..." | |
| searchPlaceholder="Filter Queues..." |
2 participants
Summary
#277
searchPlaceholderprop to the shared dashboardDataTablecomponent.Filter jobs...placeholder with table-specific placeholder text.ScreenShots
Before
After
Testing