feat(ui): translate layout and dashboard headers to Chinese#273
feat(ui): translate layout and dashboard headers to Chinese#273zxsharp wants to merge 2 commits into
Conversation
Signed-off-by: zxsharp <ishanshdimaniya@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @zxsharp! It looks like this is your first PR to volcano-sh/dashboard 🎉 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request translates various UI elements in the Volcano dashboard into Chinese, including menu items and headers. The review feedback suggests using '仪表盘' instead of '仪表板' to maintain consistency with industry standards and Kubernetes terminology. Additionally, the reviewer noted that hardcoding these strings directly into the components is a regression for internationalization and highlighted inconsistencies where terms like 'Pods' were left untranslated.
| { text: "Dashboard", icon: <HomeIcon />, path: "/dashboard" }, | ||
| { text: "Jobs", icon: <AssignmentIcon />, path: "/jobs" }, | ||
| { text: "Queues", icon: <CloudIcon />, path: "/queues" }, | ||
| { text: "仪表板", icon: <HomeIcon />, path: "/dashboard" }, |
There was a problem hiding this comment.
The term '仪表盘' is the standard translation for 'Dashboard' in the Kubernetes and cloud-native ecosystem (e.g., the official Kubernetes Dashboard). Additionally, hardcoding these strings directly replaces the English UI, which is a regression for international users. Furthermore, 'Pods' (line 44) remains untranslated, creating an inconsistent experience. Consider using a translation mapping to support multiple languages in the future.
| { text: "仪表板", icon: <HomeIcon />, path: "/dashboard" }, | |
| { text: "仪表盘", icon: <HomeIcon />, path: "/dashboard" }, |
| }} | ||
| > | ||
| Volcano Dashboard | ||
| Volcano 仪表板 |
There was a problem hiding this comment.
Use '仪表盘' instead of '仪表板' to maintain consistency with standard terminology and the sidebar items.
| Volcano 仪表板 | |
| Volcano 仪表盘 |
| > | ||
| <TitleComponent text="Volcano Dashboard" /> | ||
| <Tooltip title="Refresh Data"> | ||
| <TitleComponent text="Volcano 仪表板" /> |
There was a problem hiding this comment.
Use '仪表盘' for consistency with the main layout and industry standards.
| <TitleComponent text="Volcano 仪表板" /> | |
| <TitleComponent text="Volcano 仪表盘" /> |
Signed-off-by: zxsharp <ishanshdimaniya@gmail.com>
2 participants
What this PR does / why we need it
This PR translates the main Sidebar Layout (
Layout.jsx) and the Dashboard Header (DashboardHeader.jsx) into Chinese (Simplified).This is submitted as the Prerequisite Task for the LFX Mentorship Term 2 application.
Approach
To avoid colliding with the larger
react-i18nextarchitecture proposals and the ongoing Next.js migration (#174), I intentionally kept this PR microscopic. I translated the sections using strict inline mapping right at the render layer. This leaves the underlying component logic untouched, making it trivial to review and merge into the currentmainbranch without breaking anything or causing merge conflicts.Screenshots