test: remove duplicate TestHandleHealth function#376
Conversation
Signed-off-by: Vivek Dubey <viveksantoshkumardubey@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @vivek41-glitch! It looks like this is your first PR to volcano-sh/agentcube 🎉 |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Removes a redundant health endpoint test to reduce duplication in the router handler test suite.
Changes:
- Deleted
TestHandleHealth, which duplicated the/health/liveassertions already covered elsewhere.
There was a problem hiding this comment.
Code Review
This pull request removes the redundant TestHandleHealth test function from pkg/router/handlers_test.go, as its functionality is already covered by TestHandleHealthLive. I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #376 +/- ##
===========================================
+ Coverage 47.57% 58.00% +10.43%
===========================================
Files 30 34 +4
Lines 2819 3181 +362
===========================================
+ Hits 1341 1845 +504
+ Misses 1338 1151 -187
- Partials 140 185 +45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@acsoto @VanderChen - This PR removes a duplicate test function. All CI checks are passing. Could you please review and add /lgtm if approved? Thanks! |
Removed duplicate
TestHandleHealthfunction.TestHandleHealthLivealready covers the same test.