Skip to content

test: remove duplicate TestHandleHealth function#376

Open
vivek41-glitch wants to merge 1 commit into
volcano-sh:mainfrom
vivek41-glitch:fix-duplicate-test
Open

test: remove duplicate TestHandleHealth function#376
vivek41-glitch wants to merge 1 commit into
volcano-sh:mainfrom
vivek41-glitch:fix-duplicate-test

Conversation

@vivek41-glitch
Copy link
Copy Markdown

@vivek41-glitch vivek41-glitch commented Jun 4, 2026

Removed duplicate TestHandleHealth function. TestHandleHealthLive already covers the same test.

Signed-off-by: Vivek Dubey <viveksantoshkumardubey@gmail.com>
Copilot AI review requested due to automatic review settings June 4, 2026 19:42
@volcano-sh-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yaozengzeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot
Copy link
Copy Markdown
Contributor

Welcome @vivek41-glitch! It looks like this is your first PR to volcano-sh/agentcube 🎉

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Removes a redundant health endpoint test to reduce duplication in the router handler test suite.

Changes:

  • Deleted TestHandleHealth, which duplicated the /health/live assertions already covered elsewhere.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the redundant TestHandleHealth test function from pkg/router/handlers_test.go, as its functionality is already covered by TestHandleHealthLive. I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.00%. Comparing base (524e55e) to head (b85c308).
⚠️ Report is 119 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #376       +/-   ##
===========================================
+ Coverage   47.57%   58.00%   +10.43%     
===========================================
  Files          30       34        +4     
  Lines        2819     3181      +362     
===========================================
+ Hits         1341     1845      +504     
+ Misses       1338     1151      -187     
- Partials      140      185       +45     
Flag Coverage Δ
unittests 58.00% <ø> (+10.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vivek41-glitch
Copy link
Copy Markdown
Author

@acsoto @VanderChen - This PR removes a duplicate test function. All CI checks are passing. Could you please review and add /lgtm if approved? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants