Skip to content

Fix typo in store_valkey.go: stingsSliceResults to stringSliceResults #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zlong928 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix typo in store_valkey.go: stingsSliceResults to stringSliceResults #357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions pkg/store/store_valkey.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,17 +111,17 @@ func (vs *valkeyStore) loadSandboxesBySessionIDs(ctx context.Context, sessionIDs
sessionIDKeys = append(sessionIDKeys, vs.sessionKey(sessionID))
}
// MGet should in same slot
stingSliceResults, err := vs.cli.Do(ctx, vs.cli.B().Mget().Key(sessionIDKeys...).Build()).AsStrSlice()
stringSliceResults, err := vs.cli.Do(ctx, vs.cli.B().Mget().Key(sessionIDKeys...).Build()).AsStrSlice()
if err != nil {
return nil, fmt.Errorf("loadSandboxesBySessionIDs: Valkey MGet sandboxes failed: %w", err)
}

if len(stingSliceResults) > len(sessionIDKeys) {
return nil, fmt.Errorf("unexpected MGet result size: %d, param size: %d", len(stingSliceResults), len(sessionIDKeys))
if len(stringSliceResults) > len(sessionIDKeys) {
return nil, fmt.Errorf("unexpected MGet result size: %d, param size: %d", len(stringSliceResults), len(sessionIDKeys))
Comment on lines +119 to +120
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The condition len(stringSliceResults) > len(sessionIDKeys) is insufficient. In Valkey/Redis, the MGET command always returns exactly one result for each key provided, including nil for non-existent keys. Therefore, the length of the result slice should be exactly equal to the number of keys requested. Any discrepancy (either more or fewer results) indicates an unexpected state or protocol error. Using != ensures that the mapping between results and session IDs remains consistent.

Suggested change
if len(stringSliceResults) > len(sessionIDKeys) {
return nil, fmt.Errorf("unexpected MGet result size: %d, param size: %d", len(stringSliceResults), len(sessionIDKeys))
if len(stringSliceResults) != len(sessionIDKeys) {
return nil, fmt.Errorf("unexpected MGet result size: %d, param size: %d", len(stringSliceResults), len(sessionIDKeys))

Copy link
Copy Markdown
Contributor

@RainbowMango RainbowMango Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems sensible, but out of scope of this PR.

}

sandboxResults := make([]*types.SandboxInfo, 0, len(stingSliceResults))
for i, sandboxObjString := range stingSliceResults {
sandboxResults := make([]*types.SandboxInfo, 0, len(stringSliceResults))
for i, sandboxObjString := range stringSliceResults {
if len(sandboxObjString) == 0 {
// sandboxObjString is empty while sessionKey not exist, ignore
continue
Expand Down
Loading