Skip to content

[codex] Remove no-op config keys - #59

Merged
vnedyalk0v merged 1 commit into
devfrom
chore/remove-noop-config
Jun 23, 2026
Merged

[codex] Remove no-op config keys#59
vnedyalk0v merged 1 commit into
devfrom
chore/remove-noop-config

Conversation

@vnedyalk0v

Copy link
Copy Markdown
Owner

Summary

  • Remove config keys that were accepted by schema/defaults but never read at runtime.
  • Keep docs, defaults, schema, and TypeScript config types aligned.
  • Replace two JSON stringify/parse clones in review-comment validators with structuredClone.

Changed files

  • config/README.md
  • config/default.codeflow.json
  • docs/CONFIGURATION.md
  • schemas/codeflow.schema.json
  • src/config/codeflow-config.ts
  • src/review-comments/review-fix-validation.ts
  • src/review-comments/review-thread-triage-validation.ts
  • tests/config/validate-config.test.ts

Verification

  • npm run check passed: JSON, text safety, docs format, typecheck, and Vitest.
  • Vitest result: 63 test files, 514 tests passed.
  • git diff --check passed.

Self-review notes

  • Scope is limited to the two 100% validated findings from the ponytail audit follow-up.
  • Removed config keys are now rejected as additionalProperties by schema validation.
  • Existing behavior for needs_human, emergency reason guidance, and GitHub GraphQL review-thread handling remains hard-coded where it already was.

Related issues and PRs

  • Related issue: none provided.
  • Review comments addressed: none.

Known risks or follow-up

  • This is a schema/config cleanup and is breaking for existing .pi/codeflow.json files that still include the removed no-op keys.

@vnedyalk0v vnedyalk0v self-assigned this Jun 23, 2026
@vnedyalk0v
vnedyalk0v marked this pull request as ready for review June 23, 2026 09:26
@vnedyalk0v
vnedyalk0v merged commit f1aa0e3 into dev Jun 23, 2026
1 check passed
@vnedyalk0v
vnedyalk0v deleted the chore/remove-noop-config branch June 23, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant