Switch vllm_bench to standalone vllm-bench Rust binary#32
Open
khluu wants to merge 1 commit into
Open
Conversation
Replace the `vllm bench serve` Python CLI (run via `docker exec` inside the vllm/vllm-openai container) with the standalone vllm-bench Rust binary from github.com/vllm-project/vllm-bench, which runs on the host and talks HTTP to the served port. JSON schema is identical, so ingest_perf.py is unchanged. The binary is downloaded on first use to ~/.cache/perf-eval/ and pinned to v0.1.0 (override with VLLM_BENCH_VERSION / VLLM_BENCH_BIN). Drops the SPEED-Bench dataset code path — it needed HuggingFace download, `docker cp` of JSONL into the container, and in-container pandas install, and it was already effectively dead (all workloads use `dataset: random`). Removes the unused `speed_bench_dataset_subset` / `speed_bench_category` fields from the schema and from the four AMD workloads that still carried them. This PR was authored with assistance from Claude Code. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vllm bench servePython CLI (run viadocker execinside the vllm/vllm-openai container) for the standalone vllm-bench Rust binary, which runs on the host and talks HTTP to the served port. JSON schema is identical, soingest_perf.pyneeded no logic changes.~/.cache/perf-eval/on first use, pinned tov0.1.0. Override withVLLM_BENCH_VERSIONor point at a local build withVLLM_BENCH_BIN.lib/run_vllm_bench.sh— it needed HuggingFace download +docker cp+ in-container pandas install, and it was already effectively dead code (every workload usesdataset: random). Also remove the now-unusedspeed_bench_dataset_subset/speed_bench_categoryschema fields fromparse_workload.py, therun.shTSV reader, and the four AMD workloads (kimi_k2_5_mi300x,kimi_k2_5_mi355x,gpt_oss_120b_mi355x,deepseek_v4_pro_mi355x) that still carried them.dataset: speed_benchwarning.Net:
lib/run_vllm_bench.shshrinks from 168 → 100 lines and no longer needsdocker exec,docker cp, or any in-container pip installs.This PR was authored with assistance from Claude Code.
Test plan
bash -non every helper inlib/WORKLOAD_VLLM_BENCH_TSVreduced to 7 columnsqwen3_5_h200withBENCH_ONLY=1to confirm the binary download + host-side invocation work end-to-end on a real GPU agent