feat: support codex custom tool type#101
Open
haoshan98 wants to merge 12 commits into
Open
Conversation
Signed-off-by: haoshan98 <haoshanw@gmail.com>
haoshan98
requested review from
bbrowning,
franciscojavierarceo,
jiahuei,
leseb,
maralbahari,
noobHappylife,
qandrew and
tjtanaa
as code owners
July 14, 2026 11:41
haoshan98
marked this pull request as draft
July 14, 2026 11:41
Signed-off-by: haoshan98 <haoshanw@gmail.com>
Signed-off-by: haoshan98 <haoshanw@gmail.com>
Signed-off-by: haoshan98 <haoshanw@gmail.com> # Conflicts: # crates/agentic-server/src/handler/websocket/responses.rs # crates/agentic-server/tests/responses_websocket_test.rs
maralbahari
reviewed
Jul 16, 2026
maralbahari
reviewed
Jul 16, 2026
Signed-off-by: haoshan98 <haoshanw@gmail.com>
Signed-off-by: haoshan98 <haoshanw@gmail.com>
Signed-off-by: haoshan98 <haoshanw@gmail.com>
Signed-off-by: Hao Shan <53949959+haoshan98@users.noreply.github.com>
This reverts commit 81b6e8e. Signed-off-by: haoshan98 <haoshanw@gmail.com>
haoshan98
marked this pull request as ready for review
July 16, 2026 10:31
maralbahari
reviewed
Jul 16, 2026
Signed-off-by: haoshan98 <haoshanw@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex declares freeform tools such as
apply_patchwithtype: "custom". Unlike function tools, these declarations caninclude an opaque grammar, and their calls carry raw text in
inputrather than JSON inarguments. The typed Responsespath previously could not preserve that protocol through upstream inference, streaming, storage, and continuation.
custom_tool_callitems, andcustom_tool_call_outputresults while preserving unknown format fields.tool_choiceobjects such as{"type":"custom","name":"apply_patch"}alongside existing function choices.generate: falseprewarm path, confirming that promptand custom-tool declarations are preserved without upstream inference.
apply_patchremainsavailable after the ordinary model cache expires, with canonical-path checks that keep writes inside
/tmp.gateway WebSocket, OpenAI HTTPS/SSE, and OpenAI WebSocket recordings that preserve raw input and
custom_tool_call_output.codex exec, and interactive Codex verification workflows.