Bugfix: repeated MSER features#5
Open
machc wants to merge 1 commit intovlfeat:masterfrom
Open
Conversation
localFeatures.VlFeatMser was manually extracting bright on dark and dark on bright MSER features by calling vl_mser() twice. However, vl_mser() extracts both types of features by default, causing localFeatures.VlFeatMser.extractFeatures() to always return two copies of the same feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
localFeatures.VlFeatMserwas manually extracting bright on dark and darkon bright MSER features by calling
vl_mser()twice. However,vl_mser()extracts both types of features by default, causing
localFeatures.VlFeatMser.extractFeatures()to always return two copiesof the same feature.