fix: use Vue tooltips for rank emojis - #307
Conversation
✅ Deploy Preview for radiant-cucurucho-d09bae ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@tomatotomata - that's for the contribution! You have a merge conflict now, and did you want to move this PR out of draft, or were you waiting on something? |
4454096 to
1e2b917
Compare
|
Resolved the conflict against current I also moved the PR out of draft. I had left it there because the full local build did not finish within the available window, but the branch is ready for the updated preview and review now. |
|
@tomatotomata - could you tighten up the tooltip? We probably want 12px font size and no extra vertical padding (might require tighter line height)
|
Signed-off-by: ahmadalguydi <ahmadalgaidy@hotmail.com>
|
I tightened the tooltip styling for the rank emojis on commit |

Summary
Replaces the native
titleattributes on the rank and status emojis with the repository's existingv-tooltipdirective. This makes the explanations appear through the same Vue tooltip system already used by the application, instead of relying on the delayed browser tooltip.The change stays inside
OverallRankEmoji.vue, keeps the existing messages, and registers the existing plugin for the component.Fixes #305
Testing
corepack yarn prettier src/components/OverallRankEmoji.vue --checkpasses after formatting.corepack yarn eslint src/components/OverallRankEmoji.vuepasses.git diff --checkpasses.corepack yarn buildwas attempted, but did not finish within two minutes in this environment.