Skip to content

Fix ONCE environment variable ignorance#13

Open
dieselburner wants to merge 4 commits intovirtualzone:masterfrom
dieselburner:fix-once-env-var
Open

Fix ONCE environment variable ignorance#13
dieselburner wants to merge 4 commits intovirtualzone:masterfrom
dieselburner:fix-once-env-var

Conversation

@dieselburner
Copy link
Copy Markdown

@dieselburner dieselburner commented Jul 11, 2023

Hi there,

Here's the MR to fix the issue I have faced with ONCE environment variable being ignored, when executed via Docker.

One important note: this changes docker-compose-watcher (or, in fact, compose-updater) default value of once to false, so that it would be possible to remove -once=0 from Dockerfile, but still keeping the old behavior:

CMD ["docker-compose-watcher", "-once=0", "-printSettings"]

The reason of removing this argument from CMD above is rather simple: due to code structure command line arguments takes precedence over environment variables, which I think is the right way to go. However, keeping -once=0 will prevent ability to override behavior of passing environment variable ONCE to Docker.

Basically, this MR makes everyone happy.

Few other small things irrelevant to original issue comes as a bonus.

@dieselburner
Copy link
Copy Markdown
Author

@virtualzone I would appreciate if you could review this and merge, or provide comments what needs to be addressed.

@dieselburner
Copy link
Copy Markdown
Author

@virtualzone, it's been more than a year now since my last request. I would appreciate if you could have a quick look. Thanks.

@limdingwen
Copy link
Copy Markdown

Hi, I have merged this into my fork. Please see limdingwen#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants