Fix ONCE environment variable ignorance#13
Open
dieselburner wants to merge 4 commits intovirtualzone:masterfrom
Open
Fix ONCE environment variable ignorance#13dieselburner wants to merge 4 commits intovirtualzone:masterfrom
ONCE environment variable ignorance#13dieselburner wants to merge 4 commits intovirtualzone:masterfrom
Conversation
Author
|
@virtualzone I would appreciate if you could review this and merge, or provide comments what needs to be addressed. |
Author
|
@virtualzone, it's been more than a year now since my last request. I would appreciate if you could have a quick look. Thanks. |
|
Hi, I have merged this into my fork. Please see limdingwen#2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
Here's the MR to fix the issue I have faced with
ONCEenvironment variable being ignored, when executed via Docker.One important note: this changes
docker-compose-watcher(or, in fact,compose-updater) default value ofonceto false, so that it would be possible to remove-once=0from Dockerfile, but still keeping the old behavior:The reason of removing this argument from
CMDabove is rather simple: due to code structure command line arguments takes precedence over environment variables, which I think is the right way to go. However, keeping-once=0will prevent ability to override behavior of passing environment variableONCEto Docker.Basically, this MR makes everyone happy.
Few other small things irrelevant to original issue comes as a bonus.