Add response timestamp to API and display in chat UI#60
Open
mateenasadaf wants to merge 2 commits intovirtualcell:mainfrom
Open
Add response timestamp to API and display in chat UI#60mateenasadaf wants to merge 2 commits intovirtualcell:mainfrom
mateenasadaf wants to merge 2 commits intovirtualcell:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
As part of getting familiar with the VCell-AI codebase, I made two small
improvements — one on the backend and one on the frontend.
Changes
Backend —
backend/app/routes/llms_router.pytimestampfield to the/queryendpoint response2025-03-24T10:45:00+00:00)datetime.now(timezone.utc)instead ofdatetime.utcnow()to avoidnaive datetime bugs when the server and client are in different timezones
arguments, and return values
Frontend —
frontend/components/ChatBox.tsxtext-blue-200(right-aligned)text-slate-400(left-aligned)timestamp, it is used directly so the displayedtime reflects when the server generated the response, not when the client
received it — with a graceful fallback to
new Date()for compatibilityWhy these changes?
which helps with debugging and gives users a better sense of response times
Testing