Skip to content

[MLU] feat: add mlu support - #1

Merged
heavyrain-lzy merged 13 commits into
verl-project:mainfrom
uqyxx:mlu-plugin
Jun 22, 2026
Merged

[MLU] feat: add mlu support#1
heavyrain-lzy merged 13 commits into
verl-project:mainfrom
uqyxx:mlu-plugin

Conversation

@uqyxx

@uqyxx uqyxx commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

This pr is for supporting Cambricon MLU backend

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request registers and implements a new CNCLCheckpointEngine for collective communication checkpointing on MLU hardware, and updates MLU platform configurations to map MLU resources to GPU resources in Ray. Feedback on the new checkpoint engine highlights several critical issues: blocking ZeroMQ operations within asynchronous methods, potential runtime errors due to missing attributes on StatelessProcessGroup during finalization, uninitialized instance variables, and premature garbage collection of local ZeroMQ contexts. Additionally, improvements were suggested to handle non-contiguous weights, align buffer offsets for mixed-precision dtypes, and optimize synchronization overhead by replacing global device synchronization with stream-level synchronization.

Comment thread verl_hardware_plugin/engines/cncl_checkpoint_engine.py
Comment thread verl_hardware_plugin/engines/cncl_checkpoint_engine.py
Comment thread verl_hardware_plugin/engines/cncl_checkpoint_engine.py
Comment thread verl_hardware_plugin/engines/cncl_checkpoint_engine.py
Comment thread verl_hardware_plugin/engines/cncl_checkpoint_engine.py
Comment thread verl_hardware_plugin/engines/cncl_checkpoint_engine.py
Comment thread verl_hardware_plugin/engines/cncl_checkpoint_engine.py
Comment thread verl_hardware_plugin/engines/cncl_checkpoint_engine.py
@heavyrain-lzy

Copy link
Copy Markdown
Collaborator

Hi @uqyxx ~ Thank you for contributing to this rep. We have merged the basic plugin method in the verl. Please update this PR according to the new contributor document. You can contact me if you have any questions.

@heavyrain-lzy

Copy link
Copy Markdown
Collaborator

Hi @uqyxx, we have added FlagOS engines for multi-chips that have been verified on the Nvidia platform. You can reference this #2 to add platform, engines, usr-guide, etc.

@uqyxx
uqyxx marked this pull request as ready for review June 16, 2026 03:41
@heavyrain-lzy

Copy link
Copy Markdown
Collaborator

Hi @uqyxx, we have added FlagOS engines for multi-chips that have been verified on the Nvidia platform. You can reference this #2 to add platform, engines, usr-guide, etc.

@uqyxx Please solve the conflicts and add a user guide in the docs.

@uqyxx

uqyxx commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Hi @uqyxx, we have added FlagOS engines for multi-chips that have been verified on the Nvidia platform. You can reference this #2 to add platform, engines, usr-guide, etc.

@uqyxx Please solve the conflicts and add a user guide in the docs.

Hi @heavyrain-lzy , all done! Thx!

Comment thread docs/user_guide_mlu/README.md
@heavyrain-lzy

Copy link
Copy Markdown
Collaborator

Hi,@uqyxx, have you verified that the example executes correctly?

Comment thread docs/user_guide_mlu/quick_start.md
@uqyxx

uqyxx commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

Hi,@uqyxx, have you verified that the example executes correctly?

Yes I have tested several scripts in verl examples, can run succesfully

@heavyrain-lzy

Copy link
Copy Markdown
Collaborator

Hi @wuxibin89 , the PR has been reviewed and is ready to be merged. Do you have any comments from your perspective?

Comment thread docs/user_guide_mlu/install_guidance.md

@heavyrain-lzy heavyrain-lzy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heavyrain-lzy
heavyrain-lzy merged commit eb89c64 into verl-project:main Jun 22, 2026
@heavyrain-lzy

Copy link
Copy Markdown
Collaborator

@uqyxx Hi, I have added end-to-end validation coverage in #5, including E2E checks. Please follow the scripts: https://github.com/verl-project/verl-hardware-plugin/blob/main/scripts/baseline_grpo_gsm8k.sh and compare the result in the https://swanlab.cn/@heavyrain/verl_grpo_gsm8k_math/runs/8h196r8o/chart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants