[MLU] feat: add mlu support - #1
Conversation
There was a problem hiding this comment.
Code Review
This pull request registers and implements a new CNCLCheckpointEngine for collective communication checkpointing on MLU hardware, and updates MLU platform configurations to map MLU resources to GPU resources in Ray. Feedback on the new checkpoint engine highlights several critical issues: blocking ZeroMQ operations within asynchronous methods, potential runtime errors due to missing attributes on StatelessProcessGroup during finalization, uninitialized instance variables, and premature garbage collection of local ZeroMQ contexts. Additionally, improvements were suggested to handle non-contiguous weights, align buffer offsets for mixed-precision dtypes, and optimize synchronization overhead by replacing global device synchronization with stream-level synchronization.
|
Hi @uqyxx ~ Thank you for contributing to this rep. We have merged the basic plugin method in the |
Hi @heavyrain-lzy , all done! Thx! |
|
Hi,@uqyxx, have you verified that the example executes correctly? |
Yes I have tested several scripts in verl examples, can run succesfully |
|
Hi @wuxibin89 , the PR has been reviewed and is ready to be merged. Do you have any comments from your perspective? |
|
@uqyxx Hi, I have added end-to-end validation coverage in #5, including E2E checks. Please follow the |
This pr is for supporting Cambricon MLU backend