Skip to content

[monitor-server] fix: ipv6 support and actor isolation#112

Merged
mengchengTang merged 12 commits into
verl-project:mainfrom
tardis-key:main
Jul 14, 2026
Merged

[monitor-server] fix: ipv6 support and actor isolation#112
mengchengTang merged 12 commits into
verl-project:mainfrom
tardis-key:main

Conversation

@tardis-key

@tardis-key tardis-key commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

This PR addresses three issues:

  1. Name or Service not known
image 2. Forbidden for url in log
Failed to reload Prometheus after target update: 403 Client Error: Forbidden for url: http://[::1]:9090/-/reload
INFO:     2605:340:cd51:4900:736b:c57c:e7e8:5f97:61536 - "POST /api/v1/prometheus/targets HTTP/1.1" 200 OK
Failed to reload Prometheus after target update: 403 Client Error: Forbidden for url: http://[::1]:9090/-/reload
INFO:     2605:340:cd51:4900:18c2:e17c:d4e3:f6bb:43470 - "POST /api/v1/prometheus/targets HTTP/1.1" 200 OK
  1. Actor resource conflicts caused by long-lived actors spanning multiple jobs.

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include:
      • monitor-api, monitor-cli, monitor-collector, monitor-server, monitor-config for online monitor changes
      • recipe for offline analysis changes, including pipeline, parser, visualizer, data checker, recipe config, examples, and sample data
      • doc, ci, perf, deployment, misc for cross-cutting changes
    • If this PR involves multiple modules, separate them with , like [recipe, ci] or [monitor-server, monitor-config]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][mstx, torch_profile] feat: support timeline parsing

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates Prometheus utilities to bypass proxy settings during local reloads by disabling trust_env in a requests.Session, and strips brackets from bind addresses. It also changes the loopback address in network.py to always use 127.0.0.1. Feedback suggests retaining the conditional loopback address (::1 for IPv6) because hardcoding 127.0.0.1 breaks IPv6-only environments, and the underlying proxy issue has already been resolved by the session changes.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread rl_insight/server/network.py
@tardis-key tardis-key changed the title [monitor-server] fix: ipv6 support [monitor-server] fix: ipv6 support and actor isolation Jul 14, 2026
Comment thread rl_insight/client/ray_monitor_client.py Outdated
)
return ray.get_actor(actor_name, namespace=namespace)
except (ValueError, ray.exceptions.RayActorError):
# Actor missing or dead; fall through to create a new one.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[review] 原来的日志需要保留

Comment thread rl_insight/client/ray_monitor_client.py Outdated
# Actor missing or dead; fall through to create a new one.
pass

actor_cls = cast(Any, MonitorHubActor)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[review] 原来的try catch需要保留,主要防止多进程同时初始化的冲突

@tardis-key tardis-key force-pushed the main branch 5 times, most recently from 234913d to dabcc4d Compare July 14, 2026 13:10
@tardis-key tardis-key force-pushed the main branch 2 times, most recently from d456486 to c26b676 Compare July 14, 2026 14:51
@mengchengTang mengchengTang merged commit 631a487 into verl-project:main Jul 14, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants