[monitor-server] fix: ipv6 support and actor isolation#112
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates Prometheus utilities to bypass proxy settings during local reloads by disabling trust_env in a requests.Session, and strips brackets from bind addresses. It also changes the loopback address in network.py to always use 127.0.0.1. Feedback suggests retaining the conditional loopback address (::1 for IPv6) because hardcoding 127.0.0.1 breaks IPv6-only environments, and the underlying proxy issue has already been resolved by the session changes.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| ) | ||
| return ray.get_actor(actor_name, namespace=namespace) | ||
| except (ValueError, ray.exceptions.RayActorError): | ||
| # Actor missing or dead; fall through to create a new one. |
| # Actor missing or dead; fall through to create a new one. | ||
| pass | ||
|
|
||
| actor_cls = cast(Any, MonitorHubActor) |
There was a problem hiding this comment.
[review] 原来的try catch需要保留,主要防止多进程同时初始化的冲突
234913d to
dabcc4d
Compare
d456486 to
c26b676
Compare
What does this PR do?
This PR addresses three issues:
Checklist Before Starting
[{modules}] {type}: {description}(This will be checked by the CI){modules}include:monitor-api,monitor-cli,monitor-collector,monitor-server,monitor-configfor online monitor changesrecipefor offline analysis changes, including pipeline, parser, visualizer, data checker, recipe config, examples, and sample datadoc,ci,perf,deployment,miscfor cross-cutting changes,like[recipe, ci]or[monitor-server, monitor-config]{type}is infeat,fix,refactor,chore,test[BREAKING]to the beginning of the title.[BREAKING][mstx, torch_profile] feat: support timeline parsingTest
API and Usage Example
# Add code snippet or script demonstrating how to use thisDesign & Code Changes
Checklist Before Submitting
Important
Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.
pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always