-
Notifications
You must be signed in to change notification settings - Fork 452
WIP: register Slack Preview Deployment agents #1960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
benpankow
merged 2 commits into
benpankow/preview-agent-vercel-branch
from
benpankow/preview-agent-slack-registration
Aug 13, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
packages/eve/src/public/channels/slack/user-groups.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import { describe, expect, it } from "vitest"; | ||
|
|
||
| import { | ||
| slackUserGroupMentions, | ||
| withoutSlackUserGroupMention, | ||
| } from "#public/channels/slack/user-groups.js"; | ||
|
|
||
| describe("slackUserGroupMentions", () => { | ||
| it("returns unique opaque group ids in mention order", () => { | ||
| expect( | ||
| slackUserGroupMentions("Ask <!subteam^S123|preview> then <!subteam^S456>. <!subteam^S123>"), | ||
| ).toEqual([{ id: "S123" }, { id: "S456" }]); | ||
| }); | ||
| }); | ||
|
|
||
| describe("withoutSlackUserGroupMention", () => { | ||
| it("removes only the selected group mention", () => { | ||
| expect( | ||
| withoutSlackUserGroupMention("<!subteam^S123|preview> check <!subteam^S456>", "S123"), | ||
| ).toBe("check <!subteam^S456>"); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| const USER_GROUP_MENTION = /<!subteam\^([A-Z0-9]+)(?:\|[^>]+)?>/gu; | ||
|
|
||
| /** One Slack user-group mention found in message text. */ | ||
| export interface SlackUserGroupMention { | ||
| readonly id: string; | ||
| } | ||
|
|
||
| /** | ||
| * Returns unique Slack user-group ids mentioned in text in first-mention | ||
| * order. The parser deliberately retains Slack's opaque id rather than a | ||
| * mutable display handle so channel-owned registries can verify ownership. | ||
| */ | ||
| export function slackUserGroupMentions(text: string): readonly SlackUserGroupMention[] { | ||
| const seen = new Set<string>(); | ||
| const mentions: SlackUserGroupMention[] = []; | ||
| for (const match of text.matchAll(USER_GROUP_MENTION)) { | ||
| const id = match[1]; | ||
| if (id === undefined || seen.has(id)) continue; | ||
| seen.add(id); | ||
| mentions.push({ id }); | ||
| } | ||
| return mentions; | ||
| } | ||
|
|
||
| /** | ||
| * Removes one recognized user-group mention using the same whitespace | ||
| * normalization callers use for an empty Slack app mention. | ||
| */ | ||
| export function withoutSlackUserGroupMention(text: string, userGroupId: string): string { | ||
| return text | ||
| .replace(USER_GROUP_MENTION, (mention, id: string) => (id === userGroupId ? "" : mention)) | ||
| .replace(/\s+/gu, " ") | ||
| .trim(); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.