fix: run sandbox image as workspace owner - #1893
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Docker Image Size Summary:
|
| Metric | Baseline | Current | Delta |
|---|---|---|---|
| Image size | 583.31 MB | 583.31 MB | 0 B |
Metadata
- Current:
pull request (17aea27) - Generated at:
2026-08-10T15:27:14.747Z
Signed-off-by: Colton Padden <colton.padden@vercel.com>
cmpadden
force-pushed
the
fix/github-sandbox-workspace-owner
branch
from
August 10, 2026 15:25
14969e8 to
17aea27
Compare
cmpadden
marked this pull request as ready for review
August 10, 2026 15:35
ruiconti
approved these changes
Aug 10, 2026
AndrewBarba
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1596. The published sandbox image gives
/workspacetovercel-sandboxbut currently runs commands as root, causing GitHub channel checkout to fail Git's ownership check. The image now runs as its workspace owner, preserving passwordlesssudofor privileged setup instead of weakeningsafe.directory; the image analysis job executes the failing Git sequence as a regression test, and the sandbox bootstrap example usessudoaccordingly.Existing durable sandboxes are not rotated, so they retain their current process user and workspace state; the fix applies when a sandbox is provisioned from the updated image. This draft reaches the same core image-user correction as #1692 and adds executable image coverage and the corresponding documentation update.
Validation
pnpm docs:checkpnpm guard:invariantspnpm exec oxfmt --check .github/workflows/docker-image-size-analysis.yml docs/sandbox.mdxgit diff --checkevepackageChecklist
CONTRIBUTING.mdevepackagegit commit --signoff)