Fix duplicate GitHub link in eve.dev nav - #1220
Open
rauchg wants to merge 1 commit into
Open
Conversation
Co-authored-by: v0 <it+v0agent@vercel.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The eve.dev mobile menu showed "GitHub ↗" twice.
@vercel/geistdocsalready renders a GitHub link on its own fromconfig.github(an icon button on desktop, a "GitHub" row in the mobile sheet), so the extraGitHubentry in the site'snavarray produced a second, identical link. Reported by @Guillermo Rauch via a mobile web report.What changed
GitHubitem from thenavarray inapps/docs/geistdocs.tsx, leaving the package-rendered link as the single source.How to test
Open eve.dev on a narrow viewport, tap the hamburger menu, and confirm only one "GitHub ↗" row appears above "Vercel OSS". On desktop, the GitHub icon button in the header is unchanged.