Add deploymentEnabled reproduction fixture - #1210
Draft
vercel-gh-bot-2[bot] wants to merge 1 commit into
Draft
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#438 reports that an eve app in a monorepo can create a preview deployment even when the repository's root
git.deploymentEnabledconfiguration suppresses that branch. The Next.js projects created withvercel linkrespect the configuration, while the eve project created througheve linkdoes not.Hypothesis
Because the project-creation path determines whether Vercel receives the repository configuration, identical apps in one repository should differ only when their projects are created through different CLIs. Recreating the agent project through
vercel linkshould make it match the controls.What changed
Added
apps/fixtures/deployment-enabled-repro, a self-contained pnpm monorepo fixture with:vercel.tsthat enables deployments only formasterwebanddocsNext.js control apps created throughvercel linkeve init .scaffold, intended foreve linkThis is a reproduction fixture, not a code fix. It documents the behavior addressed by #447.
Validation
pnpm install --frozen-lockfile --ignore-scriptspasses in an isolated copy of the fixturepnpm --filter deployment-enabled-repro-web buildpassespnpm --filter deployment-enabled-repro-docs buildpassespnpm --filter deployment-enabled-repro-agent exec eve inforeports a ready compile with zero diagnosticsoxfmt --checkandoxlint --quietpass for the fixtureThe deployment outcome requires a live Vercel team and GitHub repository, so it cannot be validated locally.