Gradle 8 upgrade#223
Open
john-tadebois wants to merge 13 commits into
Open
Conversation
Author
|
@themockgraeme I have added the code review changes from #219. I could not push to your branch, so I created this one. Could you please give it a quick review? |
|
Hey guys .... This seem to take forever to merge, do we have any workarounds for this until this is merged? cc @john-tadebois john |
Author
I do not know much about the inner workings of this plugin. My team has moved on to directly use JaCoCo. I can still merge that PR if you do understand and can confirm in this chat that I can go ahead and merge this PR. |
Owner
|
#224 if someone wants to take over this project, please reach out! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I pushed this branch from themockgrateme:gradle-8-upgrade, with the fix for
POM_IMPLEMENTATION_CLASS = com.vanniktech.android.junit.jacoco.GenerationPluginAlong with themockgraeme's changes:
#219