Skip to content

Gradle 8 upgrade#223

Open
john-tadebois wants to merge 13 commits into
masterfrom
gradle-8-upgrade
Open

Gradle 8 upgrade#223
john-tadebois wants to merge 13 commits into
masterfrom
gradle-8-upgrade

Conversation

@john-tadebois

@john-tadebois john-tadebois commented Jan 3, 2024

Copy link
Copy Markdown

I pushed this branch from themockgrateme:gradle-8-upgrade, with the fix for

POM_IMPLEMENTATION_CLASS = com.vanniktech.android.junit.jacoco.GenerationPlugin

Along with themockgraeme's changes:

#219

I forked the Laimiux Gradle 8 compatible branch of the Vanniktech Jacoco plugin and made the following changes:

Removed the Laimiux publishing calls, which are specific to their system.
Upgraded the included APIs to the latest versions and made minor code changes to accommodate these.
Changed the Java / JDK version to 17, for compatibility with Gradle 8.
Upgraded the Gradle version to 8.

@john-tadebois

Copy link
Copy Markdown
Author

@themockgraeme I have added the code review changes from #219.

I could not push to your branch, so I created this one. Could you please give it a quick review?

@unamed000

Copy link
Copy Markdown

Hey guys ....

This seem to take forever to merge, do we have any workarounds for this until this is merged?

cc @john-tadebois john

@john-tadebois

Copy link
Copy Markdown
Author

Hey guys ....

This seem to take forever to merge, do we have any workarounds for this until this is merged?

cc @john-tadebois john

I do not know much about the inner workings of this plugin.

My team has moved on to directly use JaCoCo.

I can still merge that PR if you do understand and can confirm in this chat that I can go ahead and merge this PR.

@vanniktech

Copy link
Copy Markdown
Owner

#224 if someone wants to take over this project, please reach out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants