fix(compose): resolve relative volume paths to absolute before mounting#51
Merged
Merged
Conversation
Relative paths (./foo, ../bar, data/dir) in compose volumes were silently dropped because the filter only accepted sources with a leading `/`. Resolve them to absolute paths against the working directory, matching Docker Compose behavior. Fixes us#49 💘 Generated with Crush
Collapse three near-identical relative-path tests into one @test(arguments:) case to remove duplicate assertion boilerplate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relative volume paths (
./foo,../bar,data/dir) in compose services were silently dropped because the volume filter only accepted sources starting with/.What changed:
ComposeOrchestrator.resolveVolumeMounts()so it's testableURL(fileURLWithPath:)— matches Docker Compose's resolve-against-project-directory behaviorTests: 9 new unit tests covering absolute, relative (
./,../), directory-separator paths, named volume skip, anonymous volume, mixed scenarios, read-only flag preservation, and home-relative paths.Fixes #49
💘 Generated with Crush