Improve code coverage#942
Closed
Mutombe wants to merge 20 commits into
Closed
Conversation
NdibeRaymond
requested changes
Oct 22, 2023
NdibeRaymond
left a comment
Collaborator
There was a problem hiding this comment.
Hello @Mutombe, thanks for much for working on this! testing is something we are really lacking and I am glad someone is taking on that. I requested a couple of changes. Do you mind taking a look?
Removing extra spaces
Removing extra space
Removing extra space
Removing extra space
Author
Roger that. |
Collaborator
|
hello @Mutombe, I see that you still have have of the things in the previous review in this patch. I'd advise you remove them so we can merge this. I can work you through the process of doing this if you'd like:
|
Collaborator
|
also ensure that your own copy of the repository is up to date |
Author
|
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses issue #886 by introducing comprehensive tests for five views in the Projects app. These tests ensure the reliability and correctness of the views, enhancing the overall quality and stability of the application.
Changes
The following changes have been made in this pull request:
Implemented tests for the
ProjectCreateAPIView: These tests cover various scenarios related to project creation, validating inputs, handling permissions, and verifying the appropriate response codes and data.Implemented tests for the
ProjectUpdateAPIView: These tests thoroughly examine the functionality of updating project details, including edge cases, error handling, and ensuring the proper behavior of the view under different circumstances.Implemented tests for the
ProjectDeleteAPIView: These tests assess the behavior of the project deletion process, verifying that the appropriate permissions are enforced, confirming the correct response codes, and ensuring the database integrity is maintained.Implemented tests for the
ProjectDetailsAPIView: These tests comprehensively evaluate the functionality of retrieving project details, covering different scenarios, handling various input cases, and validating the correctness of the returned data.Each of these test implementations incorporates thorough test coverage to safeguard against regressions and ensure the robustness of the Projects app.
By introducing these tests, we can confidently assert the reliability and stability of these critical views, mitigating potential issues and providing a more professional and polished experience for our users.
Please review the changes and provide your feedback.