Potential fix for code scanning alert no. 1: Code injection#1136
Draft
tuxology wants to merge 1 commit into
Draft
Potential fix for code scanning alert no. 1: Code injection#1136tuxology wants to merge 1 commit into
tuxology wants to merge 1 commit into
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
All pre-commit checks passed ✅✅✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/unstructuredstudio/zubhub/security/code-scanning/1
To fix the problem, untrusted input (such as
${{ github.event.pull_request.head.ref }}) should not be used directly in shell code. Instead, its value should be first set in an environment variable via the workflow'senv:mapping, and then referenced using native shell syntax (i.e.,$head_ref) rather than${{ }}interpolation. This prevents code injection because the shell expands environment variables safely, rather than parsing as code. In.github/workflows/create_destroy_test_vm.yaml, this means we should move the assignment ofmerge_commit_sha,head_ref,target_repo, andpr_repointo theenv:section of the step, and reference them in the shell script using$merge_commit_sha,$head_ref, etc.Suggested fixes powered by Copilot Autofix. Review carefully before merging.