Skip to content

Feat/new auth flow fix#1122

Open
yokwejuste wants to merge 6 commits into
masterfrom
feat/new-auth-flow-fix
Open

Feat/new auth flow fix#1122
yokwejuste wants to merge 6 commits into
masterfrom
feat/new-auth-flow-fix

Conversation

@yokwejuste

Copy link
Copy Markdown
Collaborator

Summary

This PR is an implementation of the new auth flow.

Copy of #1081

@yokwejuste yokwejuste marked this pull request as ready for review March 2, 2024 05:02
@github-actions

github-actions Bot commented Mar 2, 2024

Copy link
Copy Markdown

pre-commit checks failed ❌❌❌
make sure you have pre-commit set up locally (see the README.md for instructions).
If you have set up pre-commit locally, you may need to undo this commit and
run "pre-commit" locally to see what the errors are.

@github-actions

github-actions Bot commented Mar 2, 2024

Copy link
Copy Markdown

pre-commit checks failed ❌❌❌
make sure you have pre-commit set up locally (see the README.md for instructions).
If you have set up pre-commit locally, you may need to undo this commit and
run "pre-commit" locally to see what the errors are.

@github-actions

github-actions Bot commented Mar 5, 2024

Copy link
Copy Markdown

pre-commit checks failed ❌❌❌
make sure you have pre-commit set up locally (see the README.md for instructions).
If you have set up pre-commit locally, you may need to undo this commit and
run "pre-commit" locally to see what the errors are.

@github-actions

github-actions Bot commented Mar 5, 2024

Copy link
Copy Markdown

pre-commit checks failed ❌❌❌
make sure you have pre-commit set up locally (see the README.md for instructions).
If you have set up pre-commit locally, you may need to undo this commit and
run "pre-commit" locally to see what the errors are.

@NdibeRaymond

Copy link
Copy Markdown
Collaborator

You should also rebase, and fix the failing pre-commit changes. I posted the link to a video I made on zulip, about how to go about that

@NdibeRaymond

Copy link
Copy Markdown
Collaborator

part of that failing pre-commit test is the little test we have on the backend for user creation. You need to update the test to make sure it passes. Right now it's failing, which is a pointer that the PR is failing. This looks to be the same PR that was reverted right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants