(activity): Activity creation changes#1104
Conversation
|
still needs rebasing right @brrkrmn ? |
| <DialogTitle> | ||
| <Typography align="center" className={clsx(commonClasses.title2, classes.dialogTitle)}> | ||
| Congratulations your Activity has been successfully created! | ||
| <Typography align="center" className={classes.dialogTitle}> |
There was a problem hiding this comment.
thanks for doing this @brrkrmn ! seeing untranslated strings stresses me out a lotttttt
There was a problem hiding this comment.
oh I know @NdibeRaymond , this part was edited in the activity details page PR which uses all text from translation, so I didn't want to redo the work here 😅
| ...formDataStep1, | ||
| ...step === 2 ? step2Values : {}, | ||
| publish: step === 2 ? true : false | ||
| publish: false |
There was a problem hiding this comment.
I wonder why we are not making it possible for a user to publish an activity immediately it is created?
There was a problem hiding this comment.
after discussing this with @tuxology we've come to agree that it should be the staff members who publish activities after making any necessary changes. That's why we now added a whole new tab for unpublished activities for staff members to see. I assume it's because we want activities to be presented in a more monitored and controlled way than projects.
|
pre-commit checks failed ❌❌❌ |
NdibeRaymond
force-pushed
the
activity-creation
branch
from
138b9c0 to
662576a
Compare
|
pre-commit checks failed ❌❌❌ |
NdibeRaymond
force-pushed
the
activity-creation
branch
from
662576a to
fe58eda
Compare
|
All pre-commit checks passed ✅✅✅ |
use translations and change publish button's label to create remove banner from activity creation form make created activities unpublished by default
NdibeRaymond
force-pushed
the
activity-creation
branch
from
fe58eda to
d68c340
Compare
|
All pre-commit checks passed ✅✅✅ |
|
@tuxology this has been rebased so you can focus on testing before merging to staging. |
2 participants
Summary
This PR addresses the changes needed for the activity creation process. The prioritized tasks were functional needs so the new design is not yet implemented.
Closes #1097
Changes
Screenshots