fix: unify onboarding internal boot state refresh#1923
Merged
Conversation
Contributor
WalkthroughReplaces per-disk Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Frontend
participant GraphQL_Server
participant OnboardingService
participant DisksService
participant DevsIniStore
Client->>Frontend: user opens internal-boot UI / clicks refresh
Frontend->>GraphQL_Server: query internalBootContext / mutation refreshInternalBootContext
GraphQL_Server->>OnboardingService: getInternalBootContext() / refreshInternalBootContext()
OnboardingService->>DisksService: getAssignableDisks()
DisksService->>DevsIniStore: read devs.ini -> build device map
DevsIniStore-->>DisksService: device map (device -> id/serial)
DisksService-->>OnboardingService: Disk[] (id, device, size, serialNum, interfaceType)
OnboardingService-->>GraphQL_Server: OnboardingInternalBootContext (assignableDisks + flags)
GraphQL_Server-->>Frontend: response with internalBootContext
Frontend-->>Client: render updated assignable disks / refresh UI state
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip CodeRabbit can use TruffleHog to scan for secrets in your code with verification capabilities.Add a TruffleHog config file (e.g. trufflehog-config.yml, trufflehog.yml) to your project to customize detectors and scanning behavior. The tool runs only when a config file is present. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6f7ca00f4a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+192
to
+193
| .filter((disk) => typeof disk.emhttpDeviceId === 'string' && disk.emhttpDeviceId.trim().length > 0) | ||
| .map((disk) => normalizeDeviceName(disk.device)) |
There was a problem hiding this comment.
emhttpDeviceId is not an unassigned-only signal in this codebase: the backend sets it for any disk that matches store.emhttp.devices (see getEmhttpDevices/findEmhttpDevice/parseDisk in api/src/unraid-api/graph/resolvers/disks/disks.service.ts, and assigned disks are covered in disks.service.spec.ts). Using that field here to build unassignedDevices causes assigned array/parity/cache/boot disks to have ASSIGNED_* codes removed, so they can appear eligible for internal boot selection and NO_UNASSIGNED_DISKS can be suppressed when no truly unassigned disks exist.
Useful? React with 👍 / 👎.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1923 +/- ##
==========================================
+ Coverage 51.55% 51.66% +0.11%
==========================================
Files 1024 1026 +2
Lines 70846 70930 +84
Branches 7814 7841 +27
==========================================
+ Hits 36522 36649 +127
+ Misses 34202 34159 -43
Partials 122 122 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
elibosley
force-pushed
the
codex/internal-boot-devs-source-of-truth
branch
from
6f7ca00 to
048ffbb
Compare
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
web/__test__/components/Onboarding/OnboardingInternalBootStep.test.ts (1)
514-515: Prefer behavior assertions over internal eligibility-code token checks.These two assertions are coupled to internal code labels and add little beyond the existing UI-state assertions in the same test.
Based on learnings: Applies to /test/components//*.ts : Test component behavior and output, not implementation details.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/__test__/components/Onboarding/OnboardingInternalBootStep.test.ts` around lines 514 - 515, Remove the two assertions that check for internal token strings ('ASSIGNED_TO_ARRAY' and 'NO_UNASSIGNED_DISKS') via wrapper.text(); instead assert the observable UI behavior or elements that those tokens are meant to influence (e.g., check absence/presence of specific labels, buttons, or messages rendered by the OnboardingInternalBootStep component using wrapper.find / wrapper.exists or wrapper.text() for user-facing strings). Update the test in OnboardingInternalBootStep.test.ts to drop the implementation-detail checks and replace them with behavior assertions tied to wrapper and the component's rendered output.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@web/__test__/components/Onboarding/OnboardingInternalBootStep.test.ts`:
- Around line 514-515: Remove the two assertions that check for internal token
strings ('ASSIGNED_TO_ARRAY' and 'NO_UNASSIGNED_DISKS') via wrapper.text();
instead assert the observable UI behavior or elements that those tokens are
meant to influence (e.g., check absence/presence of specific labels, buttons, or
messages rendered by the OnboardingInternalBootStep component using wrapper.find
/ wrapper.exists or wrapper.text() for user-facing strings). Update the test in
OnboardingInternalBootStep.test.ts to drop the implementation-detail checks and
replace them with behavior assertions tied to wrapper and the component's
rendered output.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 51b2b89f-0e99-4fd5-a10e-ce71a1cc5985
📒 Files selected for processing (2)
web/__test__/components/Onboarding/OnboardingInternalBootStep.test.tsweb/src/components/Onboarding/steps/OnboardingInternalBootStep.vue
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
web/src/components/Onboarding/steps/OnboardingInternalBootStep.vue (1)
160-166:⚠️ Potential issue | 🟠 MajorStore device selection keyed on serial number, not device name.
optionValueis set to the device name (/dev/sdx) rather than the serial number. This value flows throughselectedDevices→draftStore.internalBootSelection.devices→ the GraphQL mutation input. The API-sidecreateInternalBootPoolpasses these device names directly to thecmdAssignDiskcommands without any translation to current device paths.Device enumeration order can change across reboots (devices may be reordered as
/dev/sda,/dev/sdb, etc.). Storing unstable device names in the draft defeats the purpose of avoiding re-enumeration drift that this PR addresses. Either change the stored value to use the serial number as the stable identifier, or implement server-side remapping from serial to the current device path at pool creation time.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/src/components/Onboarding/steps/OnboardingInternalBootStep.vue` around lines 160 - 166, The selection option is currently storing unstable device names in optionValue (set to device) which flows into selectedDevices and draftStore.internalBootSelection.devices; change optionValue to use the stable serial number (serialNum) as the stored identifier (fall back to device only if serialNum is empty), keep display label built by buildDeviceLabel unchanged so UI still shows device and size, and ensure downstream usages (e.g., createInternalBootPool / cmdAssignDisk) expect serial identifiers or are adjusted to remap serial → current device path on the server if necessary.
🧹 Nitpick comments (1)
api/src/unraid-api/graph/resolvers/disks/disks.service.spec.ts (1)
547-549: Also assert mappedidin assignable disk expectations.This closes a small coverage gap and prevents regressions where only
serialNumis remapped.Suggested test assertion
expect(disks.map((disk) => disk.device)).toEqual(['/dev/sda', '/dev/sdd']); + expect(disks.map((disk) => disk.id)).toEqual(['DEVS-SERIAL-SDA', 'DEVS-SERIAL-SDD']); expect(disks.map((disk) => disk.serialNum)).toEqual(['DEVS-SERIAL-SDA', 'DEVS-SERIAL-SDD']);🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@api/src/unraid-api/graph/resolvers/disks/disks.service.spec.ts` around lines 547 - 549, Add an assertion to verify the mapped id on each returned disk to close the coverage gap: after the existing expectations that check disks.map(d => d.device) and disks.map(d => d.serialNum), add an expectation on disks.map(d => d.id) to equal the same expected id values (e.g., ['DEVS-SERIAL-SDA', 'DEVS-SERIAL-SDD']) so the test ensures the id field is correctly remapped in the disks variable used in this spec.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@web/src/components/Onboarding/steps/OnboardingInternalBootStep.vue`:
- Around line 152-158: The code currently treats disks with unknown size
(sizeMiB === null) as eligible; update the eligibility check around
toSizeMiB/disk.size so that if sizeMiB is null or non-positive it is considered
ineligible — i.e. change the condition to: if (sizeMiB === null || sizeMiB <
MIN_ELIGIBLE_DEVICE_SIZE_MIB) { ineligibilityCodes.push('TOO_SMALL'); } so disks
we cannot size are marked ineligible (use the existing ineligibilityCodes array
and symbols sizeMiB, toSizeMiB, MIN_ELIGIBLE_DEVICE_SIZE_MIB, and 'TOO_SMALL').
---
Outside diff comments:
In `@web/src/components/Onboarding/steps/OnboardingInternalBootStep.vue`:
- Around line 160-166: The selection option is currently storing unstable device
names in optionValue (set to device) which flows into selectedDevices and
draftStore.internalBootSelection.devices; change optionValue to use the stable
serial number (serialNum) as the stored identifier (fall back to device only if
serialNum is empty), keep display label built by buildDeviceLabel unchanged so
UI still shows device and size, and ensure downstream usages (e.g.,
createInternalBootPool / cmdAssignDisk) expect serial identifiers or are
adjusted to remap serial → current device path on the server if necessary.
---
Nitpick comments:
In `@api/src/unraid-api/graph/resolvers/disks/disks.service.spec.ts`:
- Around line 547-549: Add an assertion to verify the mapped id on each returned
disk to close the coverage gap: after the existing expectations that check
disks.map(d => d.device) and disks.map(d => d.serialNum), add an expectation on
disks.map(d => d.id) to equal the same expected id values (e.g.,
['DEVS-SERIAL-SDA', 'DEVS-SERIAL-SDD']) so the test ensures the id field is
correctly remapped in the disks variable used in this spec.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: b73bc708-2e58-48f7-acb0-7c15f5c01a02
⛔ Files ignored due to path filters (1)
api/src/unraid-api/cli/generated/graphql.tsis excluded by!**/generated/**
📒 Files selected for processing (13)
api/generated-schema.graphqlapi/src/unraid-api/graph/resolvers/disks/disks.model.tsapi/src/unraid-api/graph/resolvers/disks/disks.resolver.spec.tsapi/src/unraid-api/graph/resolvers/disks/disks.resolver.tsapi/src/unraid-api/graph/resolvers/disks/disks.service.spec.tsapi/src/unraid-api/graph/resolvers/disks/disks.service.tsweb/__test__/components/Onboarding/OnboardingInternalBootStep.test.tsweb/__test__/components/Onboarding/OnboardingSummaryStep.test.tsweb/src/components/Onboarding/graphql/getInternalBootContext.query.tsweb/src/components/Onboarding/steps/OnboardingInternalBootStep.vueweb/src/components/Onboarding/steps/OnboardingSummaryStep.vueweb/src/composables/gql/gql.tsweb/src/composables/gql/graphql.ts
💤 Files with no reviewable changes (1)
- api/src/unraid-api/graph/resolvers/disks/disks.model.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- web/test/components/Onboarding/OnboardingInternalBootStep.test.ts
Comment on lines
152
to
158
| const sizeBytes = disk.size; | ||
| const sizeMiB = toSizeMiB(sizeBytes); | ||
| const ineligibilityCodes = Array.from(diskEligibilityCodesByDevice.value.get(device) ?? []); | ||
| const ineligibilityCodes: InternalBootDiskEligibilityCode[] = []; | ||
| if (sizeMiB !== null && sizeMiB < MIN_ELIGIBLE_DEVICE_SIZE_MIB) { | ||
| ineligibilityCodes.push('TOO_SMALL'); | ||
| } |
Contributor
There was a problem hiding this comment.
Treat unknown-size disks as ineligible.
If disk.size is missing or non-positive, toSizeMiB() returns null but this branch still leaves the disk eligible. That later bypasses the max-size guard as well, so the wizard can submit against a drive we could not size.
💡 Minimal safeguard
- if (sizeMiB !== null && sizeMiB < MIN_ELIGIBLE_DEVICE_SIZE_MIB) {
+ if (sizeMiB === null || sizeMiB < MIN_ELIGIBLE_DEVICE_SIZE_MIB) {
ineligibilityCodes.push('TOO_SMALL');
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| const sizeBytes = disk.size; | |
| const sizeMiB = toSizeMiB(sizeBytes); | |
| const ineligibilityCodes = Array.from(diskEligibilityCodesByDevice.value.get(device) ?? []); | |
| const ineligibilityCodes: InternalBootDiskEligibilityCode[] = []; | |
| if (sizeMiB !== null && sizeMiB < MIN_ELIGIBLE_DEVICE_SIZE_MIB) { | |
| ineligibilityCodes.push('TOO_SMALL'); | |
| } | |
| const sizeBytes = disk.size; | |
| const sizeMiB = toSizeMiB(sizeBytes); | |
| const ineligibilityCodes: InternalBootDiskEligibilityCode[] = []; | |
| if (sizeMiB === null || sizeMiB < MIN_ELIGIBLE_DEVICE_SIZE_MIB) { | |
| ineligibilityCodes.push('TOO_SMALL'); | |
| } |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@web/src/components/Onboarding/steps/OnboardingInternalBootStep.vue` around
lines 152 - 158, The code currently treats disks with unknown size (sizeMiB ===
null) as eligible; update the eligibility check around toSizeMiB/disk.size so
that if sizeMiB is null or non-positive it is considered ineligible — i.e.
change the condition to: if (sizeMiB === null || sizeMiB <
MIN_ELIGIBLE_DEVICE_SIZE_MIB) { ineligibilityCodes.push('TOO_SMALL'); } so disks
we cannot size are marked ineligible (use the existing ineligibilityCodes array
and symbols sizeMiB, toSizeMiB, MIN_ELIGIBLE_DEVICE_SIZE_MIB, and 'TOO_SMALL').
- Purpose: sync generated GraphQL artifacts with current schema and operations. - Before: generated API and web files were out of date in this branch. - Why this was a problem: stale generated types can cause type drift and inconsistent build behavior. - What changed: refreshed API schema output, CLI generated GraphQL files, and web composable GraphQL outputs. - How it works: reran \ > unraid-monorepo@4.29.2 codegen /Users/ajitmehrotra/Projects/wt-pr-1923 > pnpm -r codegen Scope: 8 of 9 workspace projects web codegen$ graphql-codegen --config codegen.ts -r dotenv/config web codegen: ❯ Parse Configuration web codegen: ✔ Parse Configuration web codegen: ❯ Generate outputs web codegen: ❯ Generate to src/composables/gql/ web codegen: ❯ Load GraphQL schemas web codegen: ✔ Load GraphQL schemas web codegen: ❯ Load GraphQL documents web codegen: ✔ Load GraphQL documents web codegen: ❯ Generate web codegen: ✔ Generate web codegen: ✔ Generate to src/composables/gql/ web codegen: ✔ Generate outputs web codegen: Done packages/unraid-api-plugin-connect codegen$ MOTHERSHIP_GRAPHQL_LINK='https://staging.mothership.unraid.net/ws' graphql-codegen --config codegen.ts packages/unraid-api-plugin-connect codegen: [STARTED] Parse Configuration packages/unraid-api-plugin-connect codegen: [COMPLETED] Parse Configuration packages/unraid-api-plugin-connect codegen: [STARTED] Generate outputs packages/unraid-api-plugin-connect codegen: [STARTED] Generate to src/graphql/generated/client/ packages/unraid-api-plugin-connect codegen: [STARTED] Load GraphQL schemas packages/unraid-api-plugin-connect codegen: [COMPLETED] Load GraphQL schemas packages/unraid-api-plugin-connect codegen: [STARTED] Load GraphQL documents packages/unraid-api-plugin-connect codegen: [COMPLETED] Load GraphQL documents packages/unraid-api-plugin-connect codegen: [STARTED] Generate packages/unraid-api-plugin-connect codegen: [COMPLETED] Generate packages/unraid-api-plugin-connect codegen: [COMPLETED] Generate to src/graphql/generated/client/ packages/unraid-api-plugin-connect codegen: [COMPLETED] Generate outputs packages/unraid-api-plugin-connect codegen: Done api codegen$ graphql-codegen --config codegen.ts api codegen: [STARTED] Parse Configuration api codegen: [COMPLETED] Parse Configuration api codegen: [STARTED] Generate outputs api codegen: [STARTED] Generate to src/unraid-api/cli/generated/ api codegen: [STARTED] Load GraphQL schemas api codegen: [COMPLETED] Load GraphQL schemas api codegen: [STARTED] Load GraphQL documents api codegen: [COMPLETED] Load GraphQL documents api codegen: [STARTED] Generate api codegen: [COMPLETED] Generate api codegen: [COMPLETED] Generate to src/unraid-api/cli/generated/ api codegen: [COMPLETED] Generate outputs api codegen: Done at the monorepo root and committed only generated artifacts.
- Purpose: make web type-check pass by matching the test fixture to generated GraphQL operation types. - Before: the fixture included \, which is not present in the query result type used by the test. - Why that was a problem: TypeScript rejected the object literal and \ > unraid-monorepo@4.29.2 type-check /Users/ajitmehrotra/Projects/wt-pr-1923 > pnpm -r type-check Scope: 8 of 9 workspace projects web type-check$ vue-tsc --noEmit unraid-ui type-check$ vue-tsc --noEmit unraid-ui type-check: Done web type-check: Done api type-check$ tsc --noEmit api type-check: Done failed. - What changed: removed the extra \ field from the mocked \ payload. - How it works: the fixture now conforms exactly to the generated \ shape.
- Purpose: make web tests self-sufficient in fresh worktrees. - Before: test commands assumed unraid-ui dist artifacts already existed. - Why this was a problem: imports from @unraid/ui and @unraid/ui/styles failed when dist was missing. - What changed: added pretest, pretest:watch, and pretest:ci hooks to run build-ui-if-needed.js. - How it works: test lifecycles now trigger a conditional @unraid/ui build only when needed.
Contributor
|
This plugin has been deployed to Cloudflare R2 and is available for testing. |
Contributor
There was a problem hiding this comment.
♻️ Duplicate comments (1)
web/src/components/Onboarding/steps/OnboardingInternalBootStep.vue (1)
167-168:⚠️ Potential issue | 🟠 MajorUnknown-size disks are still treated as eligible.
At Line 167,
sizeMiB === nullis not marked ineligible, so disks with unknown/non-usable size can pass eligibility and be selected.💡 Minimal fix
- if (sizeMiB !== null && sizeMiB < MIN_ELIGIBLE_DEVICE_SIZE_MIB) { + if (sizeMiB === null || sizeMiB < MIN_ELIGIBLE_DEVICE_SIZE_MIB) { ineligibilityCodes.push('TOO_SMALL'); }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/src/components/Onboarding/steps/OnboardingInternalBootStep.vue` around lines 167 - 168, The eligibility check currently allows disks with sizeMiB === null to be considered eligible; update the logic in the function that builds ineligibilityCodes (the block that references sizeMiB and MIN_ELIGIBLE_DEVICE_SIZE_MIB) to treat unknown sizes as ineligible by pushing an appropriate code (e.g., 'UNKNOWN_SIZE' or include null in the existing 'TOO_SMALL' check) when sizeMiB is null; modify the condition that now reads against sizeMiB to instead check (sizeMiB === null || sizeMiB < MIN_ELIGIBLE_DEVICE_SIZE_MIB) or add a separate null branch that pushes to ineligibilityCodes so unknown-size disks are excluded from selection.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@web/src/components/Onboarding/steps/OnboardingInternalBootStep.vue`:
- Around line 167-168: The eligibility check currently allows disks with sizeMiB
=== null to be considered eligible; update the logic in the function that builds
ineligibilityCodes (the block that references sizeMiB and
MIN_ELIGIBLE_DEVICE_SIZE_MIB) to treat unknown sizes as ineligible by pushing an
appropriate code (e.g., 'UNKNOWN_SIZE' or include null in the existing
'TOO_SMALL' check) when sizeMiB is null; modify the condition that now reads
against sizeMiB to instead check (sizeMiB === null || sizeMiB <
MIN_ELIGIBLE_DEVICE_SIZE_MIB) or add a separate null branch that pushes to
ineligibilityCodes so unknown-size disks are excluded from selection.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: b6d286c8-b04a-4ccf-9a4b-87b7ef9dd612
⛔ Files ignored due to path filters (1)
api/src/unraid-api/cli/generated/graphql.tsis excluded by!**/generated/**
📒 Files selected for processing (22)
api/generated-schema.graphqlapi/src/__test__/store/watch/state-watch.test.tsapi/src/store/watch/state-watch.tsapi/src/unraid-api/graph/resolvers/mutation/mutation.model.tsapi/src/unraid-api/graph/resolvers/onboarding/onboarding-internal-boot.service.spec.tsapi/src/unraid-api/graph/resolvers/onboarding/onboarding-internal-boot.service.tsapi/src/unraid-api/graph/resolvers/onboarding/onboarding.model.tsapi/src/unraid-api/graph/resolvers/onboarding/onboarding.mutation.spec.tsapi/src/unraid-api/graph/resolvers/onboarding/onboarding.mutation.tsapi/src/unraid-api/graph/resolvers/onboarding/onboarding.query.spec.tsapi/src/unraid-api/graph/resolvers/onboarding/onboarding.query.tsapi/src/unraid-api/graph/resolvers/resolvers.module.tsweb/__test__/components/Onboarding/OnboardingInternalBootStep.test.tsweb/__test__/components/Onboarding/OnboardingSummaryStep.test.tsweb/package.jsonweb/src/components/Onboarding/graphql/getInternalBootContext.query.tsweb/src/components/Onboarding/graphql/refreshInternalBootContext.mutation.tsweb/src/components/Onboarding/steps/OnboardingInternalBootStep.vueweb/src/components/Onboarding/steps/OnboardingSummaryStep.vueweb/src/composables/gql/gql.tsweb/src/composables/gql/graphql.tsweb/src/locales/en.json
🚧 Files skipped from review as they are similar to previous changes (3)
- api/generated-schema.graphql
- web/test/components/Onboarding/OnboardingSummaryStep.test.ts
- web/src/components/Onboarding/graphql/getInternalBootContext.query.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Scope: 8 of 9 workspace projects
unraid-ui lint$ eslint src
web lint$ pnpm lint:eslint && pnpm lint:prettier
web lint: > @unraid/web@4.29.2 lint:eslint /Users/elibosley/Code/api/web
web lint: > eslint --cache
web lint: > @unraid/web@4.29.2 lint:prettier /Users/elibosley/Code/api/web
web lint: > prettier --check "**/*.{js,ts,tsx,vue}"
web lint: Checking formatting...
unraid-ui lint: Done
web lint: All matched files use Prettier code style!
web lint: Done
api lint$ eslint --config .eslintrc.ts src/
api lint: Done
RUN v3.2.4 /Users/elibosley/Code/api/api
stdout | src/unraid-api/graph/resolvers/onboarding/onboarding.mutation.spec.ts
[dotenv@17.2.1] injecting env (18) from .env.test -- tip: ⚙️ enable debug logging with { debug: true }
stdout | src/unraid-api/graph/resolvers/onboarding/onboarding.query.spec.ts
[dotenv@17.2.1] injecting env (18) from .env.test -- tip: ⚙️ write to custom object with { processEnv: myObject }
stdout | src/unraid-api/graph/resolvers/onboarding/onboarding-internal-boot.service.spec.ts
[dotenv@17.2.1] injecting env (18) from .env.test -- tip: ⚙️ specify custom .env file path with { path: '/custom/path/.env' }
✓ src/unraid-api/graph/resolvers/onboarding/onboarding-internal-boot.service.spec.ts (10 tests) 5ms
✓ src/unraid-api/graph/resolvers/onboarding/onboarding.query.spec.ts (1 test) 2ms
✓ src/unraid-api/graph/resolvers/onboarding/onboarding.mutation.spec.ts (8 tests) 4ms
Test Files 3 passed (3)
Tests 19 passed (19)
Start at 12:25:35
Duration 1.37s (transform 278ms, setup 2.83s, collect 613ms, tests 11ms, environment 0ms, prepare 130ms)
Scope: 8 of 9 workspace projects
unraid-ui type-check$ vue-tsc --noEmit
web type-check$ vue-tsc --noEmit
unraid-ui type-check: Done
web type-check: Done
api type-check$ tsc --noEmit
api type-check: Done in
Scope: 8 of 9 workspace projects
packages/unraid-api-plugin-health test$ echo "Error: no test specified" && exit 0 test/components/Onboarding/OnboardingInternalBootStep.test.ts test/components/Onboarding/OnboardingSummaryStep.test.ts
packages/unraid-shared test$ vitest run test/components/Onboarding/OnboardingInternalBootStep.test.ts test/components/Onboarding/OnboardingSummaryStep.test.ts
plugin test$ vitest && pnpm run test:extractor && pnpm run test:shell-detection test/components/Onboarding/OnboardingInternalBootStep.test.ts test/components/Onboarding/OnboardingSummaryStep.test.ts
unraid-ui test$ vitest test/components/Onboarding/OnboardingInternalBootStep.test.ts test/components/Onboarding/OnboardingSummaryStep.test.ts
packages/unraid-api-plugin-health test: Error: no test specified
packages/unraid-api-plugin-health test: sh: line 0: exit: too many arguments
packages/unraid-api-plugin-health test: Failed
/Users/elibosley/Code/api/packages/unraid-api-plugin-health:
ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL unraid-api-plugin-health@4.25.3 test:
echo "Error: no test specified" && exit 0 __test__/components/Onboarding/OnboardingInternalBootStep.test.ts __test__/components/Onboarding/OnboardingSummaryStep.test.tsExit status 1
web test$ vitest run test/components/Onboarding/OnboardingInternalBootStep.test.ts test/components/Onboarding/OnboardingSummaryStep.test.ts
ELIFECYCLE Test failed. See above for more details. in
Summary by CodeRabbit
New Features
Improvements