Skip to content

xgettext path - #6

Open
oleksandr-diudiun wants to merge 6 commits into
umpirsky:masterfrom
oleksandr-diudiun:master
Open

xgettext path#6
oleksandr-diudiun wants to merge 6 commits into
umpirsky:masterfrom
oleksandr-diudiun:master

Conversation

@oleksandr-diudiun

Copy link
Copy Markdown

For temporary work version I create constant for xgettext PATH in twig-gettext-extractor and add some actual comments

@umpirsky

Copy link
Copy Markdown
Owner

How about just adding setGettextCommand() to Twig/Gettext/Extractor.php. So, this class will have command attribute with default value set to xgettext?

This will allow users to have custom twig-gettext-extractor where they can set it.

@oleksandr-diudiun

Copy link
Copy Markdown
Author

ок, i will change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants