Skip to content

#47 - Not working with TWIG ~1.24 - #48

Open
cheplv wants to merge 5 commits into
umpirsky:masterfrom
cheplv:master
Open

#47 - Not working with TWIG ~1.24#48
cheplv wants to merge 5 commits into
umpirsky:masterfrom
cheplv:master

Conversation

@cheplv

@cheplv cheplv commented Oct 11, 2016

Copy link
Copy Markdown
Contributor

Add support for twig translations functions: trans and transchoice

@umpirsky

Copy link
Copy Markdown
Owner

@cheplv I think we should add this in README under setup, parser command so anyone can configure it and be more flexible over different twig versions.

Agree?

@cheplv

cheplv commented Oct 12, 2016

Copy link
Copy Markdown
Contributor Author

@umpirsky As an additional information in README - yes. Currently this project is used for translations in many projects and if someone updates twig it silently doesn't gives any translations. So this 2 things: code + readme must to be added to this project.

@umpirsky

Copy link
Copy Markdown
Owner

@cheplv I would like to avoid code changes if possible, which means if something can be achieved using Poedit configuration, it should be done that way.
If someone updates Twig and it stops working they can come to the project GitHub page and read note we added or post/search an issue and find information there.

People use this tool in many different ways and adding keywords to the code may limit some of use cases and decrease the flexibility of the tool.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants