Skip to content

Remove erroneous HTML tags from German translations#3371

Open
mstock wants to merge 1 commit into
umap-project:masterfrom
mstock:bugfix/html-in-german-translations
Open

Remove erroneous HTML tags from German translations#3371
mstock wants to merge 1 commit into
umap-project:masterfrom
mstock:bugfix/html-in-german-translations

Conversation

@mstock

@mstock mstock commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

These HTML tags only seem to appear in the German translations. As HTML tags in translations get escaped since 2828cab, they started to show up in the user interface when using the German version.

This apparently seems to be a somewhat recurring effect, the commit which added the escaping actually removed such tags, but they were then re-introduced in 12f23bc. The first time they appear seems to be 190cac3, apparently the first time these strings got translated.

Note: I'm not sure if this is the correct way to fix this kind of error in translations and I haven't tested this since I don't have a running uMap instance or development environment, so feel free to disregard this PR if there's a better/correct approach and just take this as a hint that there is an issue somewhere (in the tool chain or maybe in Transifex?) with the German translations.

While searching for related issues, I also came across #3298 - the error in the translations most likely didn't cause that problem, but it might have been hiding the underlying issue a bit.

These HTML tags only seem to appear in the German translations. As HTML
tags in translations get escaped since 2828cab, they started to show
up in the user interface when using the German version.

This apparently seems to be a somewhat recurring effect, the commit
which added the escaping actually removed such tags, but they were then
re-introduced in 12f23bc. The first time they appear seems to be
190cac3, apparently the first time these strings got translated.
@yohanboniface

Copy link
Copy Markdown
Member

Thanks!
But the thing is that I already tried to remove those (see mstock@2828cab#diff-f73b8d3069ad405ea2b4077b9089e4e439b5d7cd68cdc47a53a5b61398177ac4), so I guess we should do the cleaning on transifex directly. Could you do that ?
Otherwise I'm afraid they'll come back again at next sync.

@mstock

mstock commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for your feedback. I was actually hoping to get away without the need for a Transifex account ;). But I've created one now and seem to have sent a join request to the uMap project for German. Once this gets granted, I can take a look and check if I see something in the strings that I can actually fix.

Btw. - the Transifex link in the contribution guidelines should probably point to https://explore.transifex.com/openstreetmap/umap/, I'm just getting a 404 for the current link right now, but that might be due to me not being a member of the organization, yet.

@mstock

mstock commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

Should also be fixed in Transifex now. There actually was some sort of 'button' in their UI (which showed the HTML in a popup when clicking on it) that could just be deleted. I initially feared that this might not even be visible there. So feel free to just close this PR as this should get fixed during the next translation update if you prefer that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants