Remove Feature.pullGeometry#3369
Merged
Merged
Conversation
yohanboniface
force-pushed
the
journal
branch
2 times, most recently
from
8866723 to
004e8e5
Compare
yohanboniface
force-pushed
the
rm-pullgeometry
branch
from
edf20ef to
dfce443
Compare
Feature had both pushGeometry and pullGeometry, which was not pure in terms of flow. We first tried to use Turf to convert Leaflet internal's latlngs, but those are objects with lat/lng/alt properties, and Turf does not know nothing about that. So let's make that Feature is geojson only and the UI deals with latlngs. There are still other coupling, but that's one less!
yohanboniface
force-pushed
the
rm-pullgeometry
branch
from
dfce443 to
ea1b66f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature had both pushGeometry and pullGeometry, which was not pure
in terms of flow.
We first tried to use Turf to convert Leaflet internal's latlngs, but
those are objects with lat/lng/alt properties, and Turf does not know
nothing about that.
So let's make that Feature is geojson only and the UI deals with
latlngs.
There are still other coupling, but that's one less!