Fix nested bracket type overloading#349
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/sidepelican/mockolo/sessions/d6e0f995-9727-4e80-b08e-ab274b1fdd3c Co-authored-by: sidepelican <19257572+sidepelican@users.noreply.github.com>
Agent-Logs-Url: https://github.com/sidepelican/mockolo/sessions/dacf577a-7878-490a-a20b-fedfe29f9945 Co-authored-by: sidepelican <19257572+sidepelican@users.noreply.github.com>
|
|
fummicc1
approved these changes
May 3, 2026
Collaborator
Author
|
Thank you all for your reviews |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, mockolo fails to generate overloads for nested types like arrays.
Consider the following code, which only produces a single
foofunction for mock class./// @mockable protocol P { func foo() -> [String] func foo() -> [[String]] }The issue stems from
SwiftType.displayNamecontinuing to use a legacy ad-hoc implementation, resulting in both[String]and[[String]]being rendered as the sameString.I'll modify the implementation to properly construct
displayNamein a structured manner.